[Findit] Adding support for disabling test try jobs for given master/builder

appengine/findit/waterfall/try_job_util.py

Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 7b743498f206f95e4fecd46e67cf3952b0e70b9a..0ea4d52f0279bde54554a273b12e89e6babbbd43 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -152,6 +152,7 @@ def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
 
   tryserver_mastername, tryserver_buildername = (
       waterfall_config.GetTrybotForWaterfallBuilder(master_name, builder_name))
+
   if not tryserver_mastername or not tryserver_buildername:
     logging.info('%s, %s is not supported yet.', master_name, builder_name)
     return {}
@@ -161,13 +162,19 @@ def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
       _NeedANewTryJob(master_name, builder_name, build_number,

[stgao, 2016/04/16 06:33:15]

If _NeedANewTryJob is run, a TryJob entity is created already.
We need to fix this.

[lijeffrey, 2016/04/18 21:40:41]

Addressed in https://codereview.chromium.org/1898003002/

                       failed_steps, failure_result_map))
 
+  if (try_job_type == TryJobType.TEST and
+      waterfall_config.ShouldSkipTestTryJobs(master_name, builder_name)):
+    logging.info('Test try jobs on %s, %s are not supported yet.',
+                 master_name, builder_name)
+    return {}
+
   if need_new_try_job:
     compile_targets = (_GetFailedTargetsFromSignals(
         signals, master_name, builder_name)
                        if try_job_type == TryJobType.COMPILE else None)
     suspected_revisions = (
         _GetSuspectsForCompileFailureFromHeuristicResult(heuristic_result)
-            if try_job_type == TryJobType.COMPILE else None)
+        if try_job_type == TryJobType.COMPILE else None)
 
     pipeline = (
         swarming_tasks_to_try_job_pipeline.SwarmingTasksToTryJobPipeline(