Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: appengine/findit/handlers/test/config_test.py

Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import datetime 5 import datetime
6 import json 6 import json
7 import re 7 import re
8 import webapp2 8 import webapp2
9 import webtest 9 import webtest
10 10
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 })) 406 }))
407 self.assertFalse(config._ValidateTrybotMapping({ 407 self.assertFalse(config._ValidateTrybotMapping({
408 'master1': { 408 'master1': {
409 'builder1': { 409 'builder1': {
410 'mastername': 'tryserver1', 410 'mastername': 'tryserver1',
411 'buildername': 'trybot1', 411 'buildername': 'trybot1',
412 'strict_regex': 'a', 412 'strict_regex': 'a',
413 } 413 }
414 } 414 }
415 })) 415 }))
416 self.assertTrue(config._ValidateTrybotMapping({
417 'master1': {
418 'builder1': {
419 'mastername': 'tryserver1',
420 'buildername': 'trybot1',
421 'not_run_tests': True,
422 }
423 }
424 }))
425 self.assertFalse(config._ValidateTrybotMapping({
426 'master1': {
427 'builder1': {
428 'mastername': 'tryserver1',
429 'buildername': 'trybot1',
430 'not_run_tests': 1, # Should be a bool.
431 }
432 }
433 }))
416 self.assertFalse(config._ValidateTrybotMapping(['a'])) 434 self.assertFalse(config._ValidateTrybotMapping(['a']))
417 self.assertFalse(config._ValidateTrybotMapping({'a': ['b']})) 435 self.assertFalse(config._ValidateTrybotMapping({'a': ['b']}))
418 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': ['1']}})) 436 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': ['1']}}))
419 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': {}}})) 437 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': {}}}))
420 438
421 def testValidateTryJobSettings(self): 439 def testValidateTryJobSettings(self):
422 self.assertFalse(config._ValidateTryJobSettings([])) 440 self.assertFalse(config._ValidateTryJobSettings([]))
423 self.assertFalse(config._ValidateTryJobSettings({})) 441 self.assertFalse(config._ValidateTryJobSettings({}))
424 self.assertFalse(config._ValidateTryJobSettings({ 442 self.assertFalse(config._ValidateTryJobSettings({
425 'server_query_interval_seconds': '1', # Should be an int. 443 'server_query_interval_seconds': '1', # Should be an int.
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 'builders': _MOCK_BUILDERS_TO_TRYBOTS, 635 'builders': _MOCK_BUILDERS_TO_TRYBOTS,
618 'try_job_settings': _MOCK_TRY_JOB_SETTINGS, 636 'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
619 'swarming_settings': _MOCK_SWARMING_SETTINGS, 637 'swarming_settings': _MOCK_SWARMING_SETTINGS,
620 'version': 1, 638 'version': 1,
621 'latest_version': 1, 639 'latest_version': 1,
622 'updated_by': 'test', 640 'updated_by': 'test',
623 'updated_ts': response.json_body.get('updated_ts') 641 'updated_ts': response.json_body.get('updated_ts')
624 } 642 }
625 643
626 self.assertEquals(expected_response, response.json_body) 644 self.assertEquals(expected_response, response.json_body)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698