Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren

Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren

This function is really only relevant for LayoutSVG*Containers, and
hence has a stronger logical tie to that part of the hierarchy. For
LayoutSVGRoot it will always return false.
Also rename the |selfNeedsLayout| argument to |forceLayout|, and the
(somewhat) corresponding local variable |forceLayout] to
|forceChildLayout|.
Eliminate an unnecessary virtual call in transformToRootChanged().
Add const qualifier to didTransformToRootUpdate().

BUG=603956
Committed: https://crrev.com/51f58998a41a2ac0d379701b3f53095c1359092e
Cr-Commit-Position: refs/heads/master@{#388292}

[fs, 2016-04-19 17:19:48]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-04-19 18:53:44]

LGTM

https://codereview.chromium.org/1897263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp
(right):

https://codereview.chromium.org/1897263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp:38:
SVGLayoutSupport::layoutChildren(this, selfNeedsLayout(), transformChanged);
Can you remove this and see what tests fail, and file a bug if it's a real
issue?

[fs, 2016-04-19 19:39:56]

https://codereview.chromium.org/1897263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp
(right):

https://codereview.chromium.org/1897263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp:38:
SVGLayoutSupport::layoutChildren(this, selfNeedsLayout(), transformChanged);
On 2016/04/19 at 18:53:44, pdr wrote:
> Can you remove this and see what tests fail, and file a bug if it's a real
issue?

Yepp, I intend to.

[fs, 2016-04-19 20:11:21]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-04-19 20:11:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897263002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897263002/1

[commit-bot: I haz the power, 2016-04-19 20:17:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:15:39]

Description was changed from

==========
Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren

This function is really only relevant for LayoutSVG*Containers, and
hence has a stronger logical tie to that part of the hierarchy. For
LayoutSVGRoot it will always return false.
Also rename the |selfNeedsLayout| argument to |forceLayout|, and the
(somewhat) corresponding local variable |forceLayout] to
|forceChildLayout|.
Eliminate an unnecessary virtual call in transformToRootChanged().
Add const qualifier to didTransformToRootUpdate().

BUG=603956
==========

to

==========
Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren

This function is really only relevant for LayoutSVG*Containers, and
hence has a stronger logical tie to that part of the hierarchy. For
LayoutSVGRoot it will always return false.
Also rename the |selfNeedsLayout| argument to |forceLayout|, and the
(somewhat) corresponding local variable |forceLayout] to
|forceChildLayout|.
Eliminate an unnecessary virtual call in transformToRootChanged().
Add const qualifier to didTransformToRootUpdate().

BUG=603956

Committed: https://crrev.com/51f58998a41a2ac0d379701b3f53095c1359092e
Cr-Commit-Position: refs/heads/master@{#388292}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:40]

Patchset 1 (id:??) landed as
https://crrev.com/51f58998a41a2ac0d379701b3f53095c1359092e
Cr-Commit-Position: refs/heads/master@{#388292}