Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h

Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-1
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009 Google, Inc. All rights reserved. 4 * Copyright (C) 2009 Google, Inc. All rights reserved.
5 * Copyright (C) 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 26 matching lines...) Expand all
37 // If you have a LayoutSVGContainer, use firstChild or lastChild instead. 37 // If you have a LayoutSVGContainer, use firstChild or lastChild instead.
38 void slowFirstChild() const = delete; 38 void slowFirstChild() const = delete;
39 void slowLastChild() const = delete; 39 void slowLastChild() const = delete;
40 40
41 LayoutObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); } 41 LayoutObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
42 LayoutObject* lastChild() const { ASSERT(children() == virtualChildren()); r eturn children()->lastChild(); } 42 LayoutObject* lastChild() const { ASSERT(children() == virtualChildren()); r eturn children()->lastChild(); }
43 43
44 void paint(const PaintInfo&, const LayoutPoint&) const override; 44 void paint(const PaintInfo&, const LayoutPoint&) const override;
45 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ; 45 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ;
46 void setNeedsBoundariesUpdate() final { m_needsBoundariesUpdate = true; } 46 void setNeedsBoundariesUpdate() final { m_needsBoundariesUpdate = true; }
47 virtual bool didTransformToRootUpdate() { return false; } 47 virtual bool didTransformToRootUpdate() const { return false; }
48 bool isObjectBoundingBoxValid() const { return m_objectBoundingBoxValid; } 48 bool isObjectBoundingBoxValid() const { return m_objectBoundingBoxValid; }
49 49
50 bool selfWillPaint() const; 50 bool selfWillPaint() const;
51 51
52 bool hasNonIsolatedBlendingDescendants() const final; 52 bool hasNonIsolatedBlendingDescendants() const final;
53 53
54 const char* name() const override { return "LayoutSVGContainer"; } 54 const char* name() const override { return "LayoutSVGContainer"; }
55 55
56 FloatRect objectBoundingBox() const final { return m_objectBoundingBox; } 56 FloatRect objectBoundingBox() const final { return m_objectBoundingBox; }
57 57
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 bool m_needsBoundariesUpdate; 94 bool m_needsBoundariesUpdate;
95 mutable bool m_hasNonIsolatedBlendingDescendants : 1; 95 mutable bool m_hasNonIsolatedBlendingDescendants : 1;
96 mutable bool m_hasNonIsolatedBlendingDescendantsDirty : 1; 96 mutable bool m_hasNonIsolatedBlendingDescendantsDirty : 1;
97 }; 97 };
98 98
99 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGContainer, isSVGContainer()); 99 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGContainer, isSVGContainer());
100 100
101 } // namespace blink 101 } // namespace blink
102 102
103 #endif // LayoutSVGContainer_h 103 #endif // LayoutSVGContainer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698