Get rid of SVGLayoutSupport::filtersForceContainerLayout

Get rid of SVGLayoutSupport::filtersForceContainerLayout

Save the "has filter resource" part, and rename it to hasFilterResource.
Hoist the normalChildNeedsLayout() part into the callers together with
the comment. This makes the condition for forcing layout of children
of an <svg> (outermost) root or a container more obvious.

Also update a few places to use the new hasFilterResource helper.

BUG=603956
Committed: https://crrev.com/f7ffad51fe92305e463f4af147f67a04f8b5b1a0
Cr-Commit-Position: refs/heads/master@{#388284}

[fs, 2016-04-19 17:19:02]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2016-04-19 17:19:02]

This is the first of a string of CLs that attempts to make the various
predicates (now) in SVGLayoutSupport::layoutChildren easier to reason about (and
simpler.) At least I find this easier to comprehend and reason about, but YMMV I
guess.

[pdr., 2016-04-19 18:14:46]

LGTM

https://codereview.chromium.org/1899243002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp (right):

https://codereview.chromium.org/1899243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp:156: bool
forceLayoutOfChildren = needsLayout
This is a little confusing because the 2nd argument of layoutChildren is
"selfNeedsLayout". WDYT about renaming that to forceLayoutOfChildren or similar?
Could also push the selfNeedsLayout check into layoutChildren since all
callsites use that.

[pdr., 2016-04-19 18:51:44]

On 2016/04/19 at 18:14:46, pdr wrote:
> LGTM
> 
>
https://codereview.chromium.org/1899243002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp (right):
> 
>
https://codereview.chromium.org/1899243002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp:156: bool
forceLayoutOfChildren = needsLayout
> This is a little confusing because the 2nd argument of layoutChildren is
"selfNeedsLayout". WDYT about renaming that to forceLayoutOfChildren or similar?
Could also push the selfNeedsLayout check into layoutChildren since all
callsites use that.

I now see now that you did this in https://codereview.chromium.org/1897263002/.
LGTM as-is, selfNeedsLayout optional.

[fs, 2016-04-19 19:36:07]

On 2016/04/19 at 18:51:44, pdr wrote:
> On 2016/04/19 at 18:14:46, pdr wrote:
> > LGTM
> > 
> >
https://codereview.chromium.org/1899243002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp (right):
> > 
> >
https://codereview.chromium.org/1899243002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp:156: bool
forceLayoutOfChildren = needsLayout
> > This is a little confusing because the 2nd argument of layoutChildren is
"selfNeedsLayout". WDYT about renaming that to forceLayoutOfChildren or similar?
Could also push the selfNeedsLayout check into layoutChildren since all
callsites use that.
> 
> I now see now that you did this in
https://codereview.chromium.org/1897263002/. LGTM as-is, selfNeedsLayout
optional.

I'm going to hold of on moving selfNeedsLayout() until I've gained more insight
into the "whys" of it.

[fs, 2016-04-19 19:36:16]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-04-19 19:36:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899243002/1

[commit-bot: I haz the power, 2016-04-19 19:41:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:15:19]

Description was changed from

==========
Get rid of SVGLayoutSupport::filtersForceContainerLayout

Save the "has filter resource" part, and rename it to hasFilterResource.
Hoist the normalChildNeedsLayout() part into the callers together with
the comment. This makes the condition for forcing layout of children
of an <svg> (outermost) root or a container more obvious.

Also update a few places to use the new hasFilterResource helper.

BUG=603956
==========

to

==========
Get rid of SVGLayoutSupport::filtersForceContainerLayout

Save the "has filter resource" part, and rename it to hasFilterResource.
Hoist the normalChildNeedsLayout() part into the callers together with
the comment. This makes the condition for forcing layout of children
of an <svg> (outermost) root or a container more obvious.

Also update a few places to use the new hasFilterResource helper.

BUG=603956

Committed: https://crrev.com/f7ffad51fe92305e463f4af147f67a04f8b5b1a0
Cr-Commit-Position: refs/heads/master@{#388284}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:20]

Patchset 1 (id:??) landed as
https://crrev.com/f7ffad51fe92305e463f4af147f67a04f8b5b1a0
Cr-Commit-Position: refs/heads/master@{#388284}