third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp - Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-1

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

index 6cf4d08fb880f6175909b08318e6f86c91c4cdf2..ffed0927bdf87288d605175702123a1bf8c41066 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

@@ -155,7 +155,8 @@ void LayoutSVGRoot::layout()

// applied to it, we need to issue paint invalidations for all descendants.

bool forceLayoutOfChildren = needsLayout

|| (normalChildNeedsLayout() && SVGLayoutSupport::hasFilterResource(*this));

- SVGLayoutSupport::layoutChildren(this, forceLayoutOfChildren);

+ const bool transformToRootChanged = false;

+ SVGLayoutSupport::layoutChildren(this, forceLayoutOfChildren, transformToRootChanged);

if (m_needsBoundariesOrTransformUpdate) {

updateCachedBoundaries();