Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 1902073002: Hoist "layout size changed" check out of SVGLayoutSupport::layoutChildren (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hoist "layout size changed" check out of SVGLayoutSupport::layoutChildren For LayoutSVGRoot, this predicate can be computed quite easily, so calling layoutSizeOfNearestViewportChanged() will be an unnecessary detour. Also rearrange layoutSizeOfNearestViewportChanged() to avoid an unnecessary virtual call. BUG=603956 Committed: https://crrev.com/e5da17ed9ca012c47e7980ef258f85d2d782dd79 Cr-Commit-Position: refs/heads/master@{#388332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +10 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
fs
4 years, 8 months ago (2016-04-19 17:19:34 UTC) #2
pdr.
LGTM
4 years, 8 months ago (2016-04-19 18:49:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902073002/1
4 years, 8 months ago (2016-04-19 20:23:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/56481)
4 years, 8 months ago (2016-04-19 20:58:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902073002/1
4 years, 8 months ago (2016-04-19 21:40:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 22:36:15 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:17:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5da17ed9ca012c47e7980ef258f85d2d782dd79
Cr-Commit-Position: refs/heads/master@{#388332}

Powered by Google App Engine
This is Rietveld 408576698