Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-1
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. 5 * Copyright (C) 2009 Google, Inc.
6 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 SVGLayoutSupport::layoutResourcesIfNeeded(this); 149 SVGLayoutSupport::layoutResourcesIfNeeded(this);
150 150
151 SVGSVGElement* svg = toSVGSVGElement(node()); 151 SVGSVGElement* svg = toSVGSVGElement(node());
152 ASSERT(svg); 152 ASSERT(svg);
153 m_isLayoutSizeChanged = needsLayout || (svg->hasRelativeLengths() && oldSize != size()); 153 m_isLayoutSizeChanged = needsLayout || (svg->hasRelativeLengths() && oldSize != size());
154 // If any of this root's children need to be laid out, and a filter is 154 // If any of this root's children need to be laid out, and a filter is
155 // applied to it, we need to issue paint invalidations for all descendants. 155 // applied to it, we need to issue paint invalidations for all descendants.
156 bool forceLayoutOfChildren = needsLayout 156 bool forceLayoutOfChildren = needsLayout
157 || (normalChildNeedsLayout() && SVGLayoutSupport::hasFilterResource(*thi s)); 157 || (normalChildNeedsLayout() && SVGLayoutSupport::hasFilterResource(*thi s));
158 SVGLayoutSupport::layoutChildren(this, forceLayoutOfChildren); 158 const bool transformToRootChanged = false;
159 SVGLayoutSupport::layoutChildren(this, forceLayoutOfChildren, transformToRoo tChanged);
159 160
160 if (m_needsBoundariesOrTransformUpdate) { 161 if (m_needsBoundariesOrTransformUpdate) {
161 updateCachedBoundaries(); 162 updateCachedBoundaries();
162 m_needsBoundariesOrTransformUpdate = false; 163 m_needsBoundariesOrTransformUpdate = false;
163 } 164 }
164 165
165 m_overflow.clear(); 166 m_overflow.clear();
166 addVisualEffectOverflow(); 167 addVisualEffectOverflow();
167 168
168 if (!shouldApplyViewportClip()) { 169 if (!shouldApplyViewportClip()) {
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 updateHitTestResult(result, pointInBorderBox); 409 updateHitTestResult(result, pointInBorderBox);
409 if (result.addNodeToListBasedTestResult(node(), locationInContainer, boundsRect) == StopHitTesting) 410 if (result.addNodeToListBasedTestResult(node(), locationInContainer, boundsRect) == StopHitTesting)
410 return true; 411 return true;
411 } 412 }
412 } 413 }
413 414
414 return false; 415 return false;
415 } 416 }
416 417
417 } // namespace blink 418 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698