third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h - Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h

Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-1

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.h ('k') | third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h

index 03b3b743cca0b046b4e4bb9a4c274fa9157b4c0a..4dfbf1582f52942e94cfd25252bf0ce1ee4f717d 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h

@@ -50,7 +50,7 @@ class CORE_EXPORT SVGLayoutSupport {

STATIC_ONLY(SVGLayoutSupport);

public:

// Shares child layouting code between LayoutSVGRoot/LayoutSVG(Hidden)Container

- static void layoutChildren(LayoutObject*, bool selfNeedsLayout);

+ static void layoutChildren(LayoutObject*, bool forceLayout, bool transformChanged);

// Layout resources used by this node.

static void layoutResourcesIfNeeded(const LayoutObject*);

@@ -89,7 +89,7 @@ public:

static DashArray resolveSVGDashArray(const SVGDashArray&, const ComputedStyle&, const SVGLengthContext&);

// Determines if any ancestor's transform has changed.

- static bool transformToRootChanged(LayoutObject*);

+ static bool transformToRootChanged(const LayoutObject*);

// FIXME: These methods do not belong here.

static const LayoutSVGRoot* findTreeRootObject(const LayoutObject*);