Chromium Code Reviews

Issue 1895943002: Update Blink GC plugin to reflect that Oilpan is now always enabled. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, hans, haraken, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Blink GC plugin to reflect that Oilpan is now always enabled. With the Blink codebase having migrated to an Oilpan only state, update the GC plugin accordingly: - drop handling of RawPtr<T>, it no longer exists. - remove !ENABLE(OILPAN) specific checks. R=haraken BUG=604463 Committed: https://crrev.com/1465e995b89191c56885c93c0ca43543e9d8cad4 Cr-Commit-Position: refs/heads/master@{#388188}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+32 lines, -65 lines)
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +6 lines, -3 lines 0 comments
M tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h View 1 chunk +1 line, -3 lines 0 comments
M tools/clang/blink_gc_plugin/CheckFieldsVisitor.h View 1 chunk +2 lines, -2 lines 0 comments
M tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp View 1 chunk +12 lines, -28 lines 1 comment
M tools/clang/blink_gc_plugin/Edge.h View 3 chunks +1 line, -6 lines 0 comments
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 2 chunks +1 line, -7 lines 0 comments
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h View 1 chunk +0 lines, -1 line 0 comments
A tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.flags View 1 chunk +1 line, -0 lines 0 comments
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt View 1 chunk +4 lines, -7 lines 0 comments
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class_error.h View 1 chunk +0 lines, -1 line 0 comments
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class_error.txt View 1 chunk +4 lines, -7 lines 0 comments

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
sof
please take a look. We'll have to back out enable-oilpan support & usage by Blink ...
4 years, 8 months ago (2016-04-18 21:23:15 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-19 00:02:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895943002/1
4 years, 8 months ago (2016-04-19 12:20:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 12:24:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:26:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1465e995b89191c56885c93c0ca43543e9d8cad4
Cr-Commit-Position: refs/heads/master@{#388188}

Powered by Google App Engine