Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: tools/clang/blink_gc_plugin/Edge.h

Issue 1895943002: Update Blink GC plugin to reflect that Oilpan is now always enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/Edge.h
diff --git a/tools/clang/blink_gc_plugin/Edge.h b/tools/clang/blink_gc_plugin/Edge.h
index eca3158d75f925e1b7430991838ad4bea890c058..91e569867d8fe0ec448a9eb4acb52a5287ae3522 100644
--- a/tools/clang/blink_gc_plugin/Edge.h
+++ b/tools/clang/blink_gc_plugin/Edge.h
@@ -87,7 +87,6 @@ class Edge {
virtual bool IsValue() { return false; }
virtual bool IsRawPtr() { return false; }
- virtual bool IsRawPtrClass() { return false; }
virtual bool IsRefPtr() { return false; }
virtual bool IsOwnPtr() { return false; }
virtual bool IsMember() { return false; }
@@ -126,16 +125,13 @@ class PtrEdge : public Edge {
class RawPtr : public PtrEdge {
public:
- RawPtr(Edge* ptr, bool is_ptr_class, bool is_ref_type)
+ RawPtr(Edge* ptr, bool is_ref_type)
: PtrEdge(ptr)
- , is_ptr_class_(is_ptr_class)
, is_ref_type_(is_ref_type)
{
- assert(!(is_ptr_class_ && is_ref_type_));
}
bool IsRawPtr() { return true; }
- bool IsRawPtrClass() { return is_ptr_class_; }
LivenessKind Kind() { return kWeak; }
bool NeedsFinalization() { return false; }
TracingStatus NeedsTracing(NeedsTracingOption) {
@@ -145,7 +141,6 @@ class RawPtr : public PtrEdge {
bool HasReferenceType() { return is_ref_type_; }
private:
- bool is_ptr_class_;
bool is_ref_type_;
};

Powered by Google App Engine
This is Rietveld 408576698