Update Blink GC plugin to reflect that Oilpan is now always enabled.

tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "CheckFieldsVisitor.h"
 
 #include <cassert>
 
 #include "BlinkGCPluginOptions.h"
 #include "RecordInfo.h"
@@ skipping 67 matching lines @@
   if (stack_allocated_host_ && Parent() && Parent()->IsMember() &&
       edge->value()->HasDefinition() && !edge->value()->IsGCAllocated()) {
     invalid_fields_.push_back(std::make_pair(current_,
                                              kMemberToGCUnmanaged));
     return;
   }
 
   if (!Parent() || !edge->value()->IsGCAllocated())
     return;
 
-  // In transition mode, disallow  OwnPtr<T>, RawPtr<T> to GC allocated T's,
-  // also disallow T* in stack-allocated types.
-  if (options_.enable_oilpan) {
-    if (Parent()->IsOwnPtr() ||
-        Parent()->IsRawPtrClass() ||
-        (stack_allocated_host_ && Parent()->IsRawPtr())) {
-      invalid_fields_.push_back(std::make_pair(
-          current_, InvalidSmartPtr(Parent())));
-      return;
-    }
-    if (options_.warn_raw_ptr && Parent()->IsRawPtr()) {
-      if (static_cast<RawPtr*>(Parent())->HasReferenceType()) {
-        invalid_fields_.push_back(std::make_pair(
-            current_, kReferencePtrToGCManagedWarning));
-      } else {
-        invalid_fields_.push_back(std::make_pair(
-            current_, kRawPtrToGCManagedWarning));
-      }
-    }
-    return;
-  }
-
-  if (Parent()->IsRawPtr() || Parent()->IsOwnPtr()) {
+  // Disallow  OwnPtr<T>, RefPtr<T> and T* to stack-allocated types.
+  if (Parent()->IsOwnPtr() ||
+      (Parent()->IsRefPtr() && !edge->value()->IsGCRefCounted()) ||

[sof, 2016/04/18 21:23:15]

Note: this RefPtr<T> check wasn't previously done with enable-oilpan, but now
is. (There is test coverage for this, but it implicitly relied on the test being
run without enable-oilpan..)

I think it has merit to catch&report such misuse of RefPtr<> as a plugin error,
but code using it will fail for other reasons as well. (e.g., no ref()/deref()
present on T.)

+      (stack_allocated_host_ && Parent()->IsRawPtr())) {
     invalid_fields_.push_back(std::make_pair(
         current_, InvalidSmartPtr(Parent())));
     return;
   }
-
-  if (Parent()->IsRefPtr() && !edge->value()->IsGCRefCounted()) {
-    invalid_fields_.push_back(std::make_pair(
-        current_, InvalidSmartPtr(Parent())));
-    return;
+  if (options_.warn_raw_ptr && Parent()->IsRawPtr()) {
+    if (static_cast<RawPtr*>(Parent())->HasReferenceType()) {
+      invalid_fields_.push_back(std::make_pair(
+          current_, kReferencePtrToGCManagedWarning));
+    } else {
+      invalid_fields_.push_back(std::make_pair(
+          current_, kRawPtrToGCManagedWarning));
+    }
   }
 }
 
 void CheckFieldsVisitor::AtCollection(Collection* edge) {
   if (edge->on_heap() && Parent() && Parent()->IsOwnPtr())
     invalid_fields_.push_back(std::make_pair(current_, kOwnPtrToGCManaged));
 }
 
 bool CheckFieldsVisitor::IsWarning(Error error) {
   if (error == kRawPtrToGCManagedWarning)
@@ skipping 19 matching lines @@
       return kReferencePtrToGCManaged;
     else
       return kRawPtrToGCManaged;
   }
   if (ptr->IsRefPtr())
     return kRefPtrToGCManaged;
   if (ptr->IsOwnPtr())
     return kOwnPtrToGCManaged;
   assert(false && "Unknown smart pointer kind");
 }