tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt - Issue 1895943002: Update Blink GC plugin to reflect that Oilpan is now always enabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt

Issue 1895943002: Update Blink GC plugin to reflect that Oilpan is now always enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp ('K') | « tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.flags ('k') | tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class_error.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 In file included from raw_ptr_to_gc_managed_class.cpp:5:	1 In file included from raw_ptr_to_gc_managed_class.cpp:5:

2 ./raw_ptr_to_gc_managed_class.h:14:1: warning: [blink-gc] Class 'PartObject' con tains invalid fields.	2 ./raw_ptr_to_gc_managed_class.h:14:1: warning: [blink-gc] Class 'PartObject' con tains invalid fields.

3 class PartObject {	3 class PartObject {

4 ^	4 ^

5 ./raw_ptr_to_gc_managed_class.h:19:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC managed class declared here:	5 ./raw_ptr_to_gc_managed_class.h:19:5: note: [blink-gc] Raw pointer field 'm_rawO bj' to a GC managed class declared here:

6 RawPtr<HeapObject> m_obj;

7 ^

8 ./raw_ptr_to_gc_managed_class.h:20:5: note: [blink-gc] Raw pointer field 'm_rawO bj' to a GC managed class declared here:

9 HeapObject* m_rawObj;	6 HeapObject* m_rawObj;

10 ^	7 ^

11 ./raw_ptr_to_gc_managed_class.h:21:5: note: [blink-gc] Reference pointer field ' m_refObj' to a GC managed class declared here:	8 ./raw_ptr_to_gc_managed_class.h:20:5: note: [blink-gc] Reference pointer field ' m_refObj' to a GC managed class declared here:

12 HeapObject& m_refObj;	9 HeapObject& m_refObj;

13 ^	10 ^

14 ./raw_ptr_to_gc_managed_class.h:24:1: warning: [blink-gc] Class 'HeapObject' con tains invalid fields.	11 ./raw_ptr_to_gc_managed_class.h:23:1: warning: [blink-gc] Class 'HeapObject' con tains invalid fields.

15 class HeapObject : public GarbageCollected<HeapObject> {	12 class HeapObject : public GarbageCollected<HeapObject> {

16 ^	13 ^

17 ./raw_ptr_to_gc_managed_class.h:29:5: note: [blink-gc] Raw pointer field 'm_objs ' to a GC managed class declared here:	14 ./raw_ptr_to_gc_managed_class.h:28:5: note: [blink-gc] Raw pointer field 'm_objs ' to a GC managed class declared here:

18 HeapVector<HeapObject*> m_objs;	15 HeapVector<HeapObject*> m_objs;

19 ^	16 ^

20 2 warnings generated.	17 2 warnings generated.

OLD	NEW