Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 1895943002: Update Blink GC plugin to reflect that Oilpan is now always enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This clang plugin checks various invariants of the Blink garbage 5 // This clang plugin checks various invariants of the Blink garbage
6 // collection infrastructure. 6 // collection infrastructure.
7 // 7 //
8 // Errors are described at: 8 // Errors are described at:
9 // http://www.chromium.org/developers/blink-gc-plugin-errors 9 // http://www.chromium.org/developers/blink-gc-plugin-errors
10 10
(...skipping 16 matching lines...) Expand all
27 CompilerInstance& instance, 27 CompilerInstance& instance,
28 llvm::StringRef ref) { 28 llvm::StringRef ref) {
29 return llvm::make_unique<BlinkGCPluginConsumer>(instance, options_); 29 return llvm::make_unique<BlinkGCPluginConsumer>(instance, options_);
30 } 30 }
31 31
32 virtual bool ParseArgs(const CompilerInstance& instance, 32 virtual bool ParseArgs(const CompilerInstance& instance,
33 const std::vector<std::string>& args) { 33 const std::vector<std::string>& args) {
34 bool parsed = true; 34 bool parsed = true;
35 35
36 for (size_t i = 0; i < args.size() && parsed; ++i) { 36 for (size_t i = 0; i < args.size() && parsed; ++i) {
37 if (args[i] == "enable-oilpan") { 37 // TODO(sof): remove this case once a version of the GC plugin
38 options_.enable_oilpan = true; 38 // has rolled which has enable-oilpan-always baked in _and_
39 } else if (args[i] == "dump-graph") { 39 // Blink no longer passes in the option (cf. Source/config.gyp)
40 if (args[i] == "enable-oilpan")
41 continue;
42 if (args[i] == "dump-graph") {
40 options_.dump_graph = true; 43 options_.dump_graph = true;
41 } else if (args[i] == "warn-raw-ptr") { 44 } else if (args[i] == "warn-raw-ptr") {
42 options_.warn_raw_ptr = true; 45 options_.warn_raw_ptr = true;
43 } else if (args[i] == "warn-unneeded-finalizer") { 46 } else if (args[i] == "warn-unneeded-finalizer") {
44 options_.warn_unneeded_finalizer = true; 47 options_.warn_unneeded_finalizer = true;
45 } else { 48 } else {
46 parsed = false; 49 parsed = false;
47 llvm::errs() << "Unknown blink-gc-plugin argument: " << args[i] << "\n"; 50 llvm::errs() << "Unknown blink-gc-plugin argument: " << args[i] << "\n";
48 } 51 }
49 } 52 }
50 53
51 return parsed; 54 return parsed;
52 } 55 }
53 56
54 private: 57 private:
55 BlinkGCPluginOptions options_; 58 BlinkGCPluginOptions options_;
56 }; 59 };
57 60
58 static FrontendPluginRegistry::Add<BlinkGCPluginAction> X( 61 static FrontendPluginRegistry::Add<BlinkGCPluginAction> X(
59 "blink-gc-plugin", 62 "blink-gc-plugin",
60 "Check Blink GC invariants"); 63 "Check Blink GC invariants");
OLDNEW
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h » ('j') | tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698