tools/clang/blink_gc_plugin/RecordInfo.cpp - Issue 1895943002: Update Blink GC plugin to reflect that Oilpan is now always enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.cpp

Issue 1895943002: Update Blink GC plugin to reflect that Oilpan is now always enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp ('K') | « tools/clang/blink_gc_plugin/Edge.h ('k') | tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/RecordInfo.cpp

diff --git a/tools/clang/blink_gc_plugin/RecordInfo.cpp b/tools/clang/blink_gc_plugin/RecordInfo.cpp

index b4937abd20f55a45757302c9d7f007d25de733e2..2f17234830a92d6916a2a9eebb752dd03c75b95a 100644

--- a/tools/clang/blink_gc_plugin/RecordInfo.cpp

+++ b/tools/clang/blink_gc_plugin/RecordInfo.cpp

@@ -584,7 +584,7 @@ Edge* RecordInfo::CreateEdge(const Type* type) {

if (type->isPointerType() || type->isReferenceType()) {

if (Edge* ptr = CreateEdge(type->getPointeeType().getTypePtrOrNull()))

- return new RawPtr(ptr, false, type->isReferenceType());

+ return new RawPtr(ptr, type->isReferenceType());

return 0;

}

@@ -597,12 +597,6 @@ Edge* RecordInfo::CreateEdge(const Type* type) {

TemplateArgs args;

- if (Config::IsRawPtr(info->name()) && info->GetTemplateArgs(1, &args)) {

- if (Edge* ptr = CreateEdge(args[0]))

- return new RawPtr(ptr, true, false);

- return 0;

- }

if (Config::IsRefPtr(info->name()) && info->GetTemplateArgs(1, &args)) {

if (Edge* ptr = CreateEdge(args[0]))

return new RefPtr(ptr);