Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual). (Closed)

Created:
4 years, 8 months ago by EhsanK
Modified:
4 years, 8 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Browser Side Text Input State Tracking for OOPIF (Manual). The original patch (https://codereview.chromium.org/1652483002/) led to many regressions. This CL is a manual revert of that patch, plus several dependent CLs that landed subsequently. Revert "Browser Side Text Input State Tracking for OOPIF." This reverts commit 2bd4a2f0c0f114979d47f4498ea1bce9b091591e. Revert "Disable WebViewTextInputStateInteractiveTest.TopLevelWebContentsTracksCorrectly on Win" This reverts commit ce2d8a33e2f0b9c742a67ba47618eb9e9172d825. Revert "Disable WebViewTextInputStateInteractiveTest.TopLevelWebContentsTracksCorrectly on Mac" This reverts commit 83e4dfa6bc12f0fb1a5da73fc82f19776a158c75. Revert "Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor." This reverts commit 0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f. Revert "Add the missing text input state tracking code to RenderWidgetHostViewMac." This reverts commit 46248c7ed4872cffc4ebb0b9da458678f7d7e7a3. Revert "Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate" This reverts commit 5292d041d34d49e8c3e851a0e21504a983e5be57. BUG=578168, 546645, 601570, 601738, 602144, 602488, 602926, 602954, 603209, 603676, 603886 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c Cr-Commit-Position: refs/heads/master@{#387715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -962 lines) Patch
M chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc View 4 chunks +0 lines, -150 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/background.js View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/guest.html View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.html View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js View 1 chunk +0 lines, -38 lines 0 comments Download
M content/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 3 chunks +2 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +1 line, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +12 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +12 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 5 chunks +26 lines, -32 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +1 line, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 8 chunks +6 lines, -31 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 4 chunks +0 lines, -50 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +14 lines, -23 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M content/browser/site_per_process_browsertest.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 3 chunks +2 lines, -222 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +0 lines, -40 lines 0 comments Download
D content/common/text_input_state.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/common/text_input_state.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/view_messages.h View 4 chunks +40 lines, -16 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +0 lines, -18 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +1 line, -2 lines 0 comments Download
D content/test/data/textinput/page_with_input.html View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/textinput/page_with_input_iframeX2_input.html View 1 chunk +0 lines, -12 lines 0 comments Download
M content/test/test_render_view_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889313002/1
4 years, 8 months ago (2016-04-15 20:27:10 UTC) #4
lazyboy
chrome/* LGTM.
4 years, 8 months ago (2016-04-15 21:19:31 UTC) #7
Charlie Reis
content/ LGTM.
4 years, 8 months ago (2016-04-15 21:21:11 UTC) #9
dcheng
rs lgtm for ipc changes
4 years, 8 months ago (2016-04-15 21:25:11 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 21:52:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889313002/1
4 years, 8 months ago (2016-04-15 22:00:11 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 22:09:48 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c Cr-Commit-Position: refs/heads/master@{#387715}
4 years, 8 months ago (2016-04-15 22:10:58 UTC) #20
kinaba
On 2016/04/15 22:10:58, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 8 months ago (2016-04-16 02:42:24 UTC) #21
Charlie Reis
4 years, 8 months ago (2016-04-18 21:21:22 UTC) #22
Message was sent while issue was closed.
On 2016/04/16 02:42:24, kinaba wrote:
> On 2016/04/15 22:10:58, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c
> > Cr-Commit-Position: refs/heads/master@{#387715}
> 
> The revert needs to be merged to M51 branch as well.

Yep.  Done in https://codereview.chromium.org/1898803002.

Powered by Google App Engine
This is Rietveld 408576698