Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index e136c089a42ebe0a20b12be03c0e3ffb08ff0c50..1532054100ce99928c685a3c5d989ac12cb69f2e 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -613,9 +613,6 @@ class CONTENT_EXPORT WebContentsImpl
const std::vector<uint8_t>& proto) override;
void OnRenderFrameProxyVisibilityChanged(bool visible) override;
void SendScreenRects() override;
- const TextInputState* GetTextInputState() override;
- void UpdateTextInputState(RenderWidgetHostViewBase* rwhv,
- bool text_input_state_changed) override;
// RenderFrameHostManager::Delegate ------------------------------------------
@@ -1359,13 +1356,6 @@ private:
bool page_scale_factor_is_one_;
- // The RWHV which is currently focused.
- base::WeakPtr<RenderWidgetHostViewBase> view_with_active_text_input_;
-
- // A copy of the text input state from |view_with_active_text_input_| when
- // there exists one, or empty (type == ui::TEXT_INPUT_TYPE_NONE) if otherwise.
- std::unique_ptr<TextInputState> text_input_state_;
-
base::WeakPtrFactory<WebContentsImpl> loading_weak_factory_;
base::WeakPtrFactory<WebContentsImpl> weak_factory_;
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698