Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mus.cc

Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mus.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_mus.cc b/content/browser/renderer_host/render_widget_host_view_mus.cc
index a1701347c9fecbecc7b274db5342b0d7f271c4a1..50a9df37cd380dedf9c78c6fc4b9e914cb2d247b 100644
--- a/content/browser/renderer_host/render_widget_host_view_mus.cc
+++ b/content/browser/renderer_host/render_widget_host_view_mus.cc
@@ -12,7 +12,6 @@
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/common/render_widget_window_tree_client_factory.mojom.h"
-#include "content/common/text_input_state.h"
#include "content/public/common/mojo_shell_connection.h"
#include "services/shell/public/cpp/connector.h"
#include "ui/aura/client/screen_position_client.h"
@@ -124,10 +123,6 @@ void RenderWidgetHostViewMus::RenderProcessGone(base::TerminationStatus status,
}
void RenderWidgetHostViewMus::Destroy() {
- // The WebContentsImpl should be notified about us so that it will not hold
- // an invalid text input state which was due to active text on this view.
- NotifyHostDelegateAboutShutdown();
-
delete aura_window_;
}
@@ -191,9 +186,9 @@ void RenderWidgetHostViewMus::UpdateCursor(const WebCursor& cursor) {
void RenderWidgetHostViewMus::SetIsLoading(bool is_loading) {
}
-void RenderWidgetHostViewMus::UpdateInputMethodIfNecessary(
- bool text_input_state_changed) {
- // TODO: Implement the IME logic when input state changes.
+void RenderWidgetHostViewMus::TextInputStateChanged(
+ const ViewHostMsg_TextInputState_Params& params) {
+ // TODO(fsamuel): Implement an IME mojo app.
}
void RenderWidgetHostViewMus::ImeCancelComposition() {
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mus.h ('k') | content/browser/site_per_process_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698