content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.h ('k') | content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index 0a548e415c14f7330ae9cfa2c2f4310a597e9358..192b35400c387589308eebbbe3b3c8f94587d368 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -219,6 +219,11 @@ void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) {

NOTREACHED();

}

+void RenderWidgetHostViewChildFrame::TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) {

+ // TODO(kenrb): Implement.

void RenderWidgetHostViewChildFrame::RenderProcessGone(

base::TerminationStatus status,

int error_code) {

@@ -241,10 +246,6 @@ void RenderWidgetHostViewChildFrame::Destroy() {

// RenderWidgetHostInputEventRouter afterwards.

NotifyObserversAboutShutdown();

- // If this view has an active text input, the RenderWidgetHostDelegate should

- // be notified.

- NotifyHostDelegateAboutShutdown();

host_->SetView(NULL);

host_ = NULL;

base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);