Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1898803002: Revert "Browser Side Text Input State Tracking for OOPIF." (Closed)

Created:
4 years, 8 months ago by EhsanK
Modified:
4 years, 8 months ago
Reviewers:
kenrb, Charlie Reis, lazyboy
CC:
chromium-reviews, extensions-reviews_chromium.org, kalyank, creis+watch_chromium.org, yusukes+watch_chromium.org, mlamouri+watch-content_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert "Browser Side Text Input State Tracking for OOPIF." The original patch (https://codereview.chromium.org/1652483002/) led to many regressions. This CL is a manual revert of that patch, plus several dependent CLs that landed subsequently. Revert "Browser Side Text Input State Tracking for OOPIF." This reverts commit 2bd4a2f0c0f114979d47f4498ea1bce9b091591e. Revert "Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor." This reverts commit 0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f. Revert "Add the missing text input state tracking code to RenderWidgetHostViewMac." This reverts commit 73a3921eff94c55d259dac5d1536a6b4bc88345a. BUG=578168, 546645, 601424, 601570, 601738, 602144, 602488, 602926, 602954, 603209, 603676, 603886 NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -886 lines) Patch
M chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc View 4 chunks +0 lines, -108 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/background.js View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/guest.html View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.html View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js View 1 chunk +0 lines, -27 lines 0 comments Download
M content/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 3 chunks +2 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +1 line, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +12 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +12 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 5 chunks +26 lines, -32 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 8 chunks +6 lines, -31 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 4 chunks +0 lines, -50 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +14 lines, -23 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M content/browser/site_per_process_browsertest.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 3 chunks +2 lines, -213 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +0 lines, -40 lines 0 comments Download
D content/common/text_input_state.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/common/text_input_state.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/view_messages.h View 4 chunks +40 lines, -16 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +0 lines, -18 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +1 line, -2 lines 0 comments Download
D content/test/data/textinput/page_with_input.html View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/textinput/page_with_input_iframeX2_input.html View 1 chunk +0 lines, -12 lines 0 comments Download
M content/test/test_render_view_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Charlie Reis
LGTM for reverting from M51 branch.
4 years, 8 months ago (2016-04-18 20:06:53 UTC) #6
kenrb
lgtm
4 years, 8 months ago (2016-04-18 20:08:19 UTC) #7
lazyboy
lgtm for merging to m51.
4 years, 8 months ago (2016-04-18 20:09:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898803002/1
4 years, 8 months ago (2016-04-18 20:42:42 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:45:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698