content/renderer/render_view_browsertest.cc - Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 4e033d2d766a3407ac45fba204b70b210effbce8..f630202fbdc32ba61aba2559c3c59806d4f563cd 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -27,7 +27,6 @@

#include "content/common/frame_replication_state.h"

#include "content/common/site_isolation_policy.h"

#include "content/common/ssl_status_serialization.h"

-#include "content/common/text_input_state.h"

#include "content/common/view_messages.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/native_web_keyboard_event.h"

@@ -1125,7 +1124,7 @@ TEST_F(RenderViewImplTest, OnImeTypeChanged) {

EXPECT_EQ(ViewHostMsg_TextInputStateChanged::ID, msg->type());

ViewHostMsg_TextInputStateChanged::Param params;

ViewHostMsg_TextInputStateChanged::Read(msg, &params);

- TextInputState p = base::get<0>(params);

+ ViewHostMsg_TextInputState_Params p = base::get<0>(params);

ui::TextInputType type = p.type;

ui::TextInputMode input_mode = p.mode;

bool can_compose_inline = p.can_compose_inline;

« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »