Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1889313002: Revert of Browser Side Text Input State Tracking for OOPIF (Manual). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index cbd5bc81615d4c0e450d6b5c28030d295d5e4b29..df29ba938f707e1ade5534c11005abf071650d54 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -57,7 +57,6 @@
#include "content/common/host_shared_bitmap_manager.h"
#include "content/common/input_messages.h"
#include "content/common/resize_params.h"
-#include "content/common/text_input_state.h"
#include "content/common/view_messages.h"
#include "content/public/browser/native_web_keyboard_event.h"
#include "content/public/browser/notification_service.h"
@@ -1730,7 +1729,7 @@ void RenderWidgetHostImpl::SetTouchEventEmulationEnabled(
}
void RenderWidgetHostImpl::OnTextInputStateChanged(
- const TextInputState& params) {
+ const ViewHostMsg_TextInputState_Params& params) {
if (view_)
view_->TextInputStateChanged(params);
}
@@ -2057,11 +2056,6 @@ void RenderWidgetHostImpl::DelayedAutoResized() {
}
void RenderWidgetHostImpl::DetachDelegate() {
- // If |view_| has active text input state, it will not be able to update the
- // |delegate_| about shut down and losing the state (see crbug.com/602144).
- if (view_)
- view_->TextInputStateChanged(TextInputState());
-
delegate_ = NULL;
}
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698