Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1878943009: Subzero. ARM32. Vector casts. (Closed)

Created:
4 years, 8 months ago by John
Modified:
4 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adds i1 sext #

Patch Set 3 : Unscalarize vector trunc from i(8|16|32) to i1 #

Patch Set 4 : Implements fpto[us]i and [us]itofp vector convertions #

Patch Set 5 : Adds vcvt assembler lit tests. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -102 lines) Patch
M src/IceAssemblerARM32.h View 1 2 3 3 chunks +31 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 3 4 chunks +141 lines, -2 lines 0 comments Download
M src/IceInstARM32.h View 1 2 3 4 chunks +25 lines, -2 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 3 5 chunks +62 lines, -2 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 4 15 chunks +102 lines, -51 lines 0 comments Download
M tests_lit/assembler/arm32/cmp-vec.ll View 2 chunks +2 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/vcvt.f32.s32.ll View 1 2 3 4 1 chunk +14 lines, -0 lines 2 comments Download
M tests_lit/assembler/arm32/vcvt.f32.u32.ll View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/vcvt.s32.f32.ll View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/vcvt.u32.f32.ll View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/vec-move.ll View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
A tests_lit/assembler/arm32/vec-sh-imm.ll View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 1 2 3 4 14 chunks +63 lines, -40 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
John
4 years, 8 months ago (2016-04-14 15:05:33 UTC) #4
Eric Holk
lgtm
4 years, 8 months ago (2016-04-14 17:40:39 UTC) #5
John
Committed patchset #5 (id:80001) manually as e88c7deb72049a08ecad8bb8f9ed3696c9415b0e (presubmit successful).
4 years, 8 months ago (2016-04-14 18:51:42 UTC) #7
Jim Stichnoth
lgtm https://codereview.chromium.org/1878943009/diff/80001/tests_lit/assembler/arm32/vcvt.f32.s32.ll File tests_lit/assembler/arm32/vcvt.f32.s32.ll (right): https://codereview.chromium.org/1878943009/diff/80001/tests_lit/assembler/arm32/vcvt.f32.s32.ll#newcode49 tests_lit/assembler/arm32/vcvt.f32.s32.ll:49: ; IASM-NOT: vcvt.f32.s32 It might be "safer" to ...
4 years, 8 months ago (2016-04-14 21:17:16 UTC) #8
John
4 years, 8 months ago (2016-04-14 21:22:11 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1878943009/diff/80001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vcvt.f32.s32.ll (right):

https://codereview.chromium.org/1878943009/diff/80001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vcvt.f32.s32.ll:49: ; IASM-NOT:    vcvt.f32.s32
On 2016/04/14 21:17:16, stichnot wrote:
> It might be "safer" to check against just "vcvt" like above.

Done (in the next CL.)

Powered by Google App Engine
This is Rietveld 408576698