Issue 18771004: Move gaussianBlur functionality to src\effects

Issue 18771004: Move gaussianBlur functionality to src\effects (Closed)

Created:
7 years, 5 months ago by robertphillips

Modified:
7 years, 5 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, tfarina

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move gaussianBlur functionality to src\effects

Patch Set 2 : Addressed code review issues #

Patch Set 3 : Renamed SkBlurUtils to SkGpuBlurUtils #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -198 lines)			Patch
M	gyp/effects.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/gpu/GrContext.h	View	1 2	1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/effects/SkBlurImageFilter.cpp	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
A	src/effects/SkGpuBlurUtils.h	View	1 2	1 chunk	+43 lines, -0 lines	0 comments	Download
A	src/effects/SkGpuBlurUtils.cpp	View	1 2	1 chunk	+187 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2	4 chunks	+0 lines, -178 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

tinytiny nits below. https://codereview.chromium.org/18771004/diff/1/src/effects/SkBlurUtils.cpp File src/effects/SkBlurUtils.cpp (right): https://codereview.chromium.org/18771004/diff/1/src/effects/SkBlurUtils.cpp#newcode9 src/effects/SkBlurUtils.cpp:9: #include "SkRect.h" can we have a ...

7 years, 5 months ago (2013-07-13 22:19:30 UTC) #2

robertphillips

https://codereview.chromium.org/18771004/diff/1/src/effects/SkBlurUtils.cpp File src/effects/SkBlurUtils.cpp (right): https://codereview.chromium.org/18771004/diff/1/src/effects/SkBlurUtils.cpp#newcode9 src/effects/SkBlurUtils.cpp:9: #include "SkRect.h" On 2013/07/13 22:19:30, tfarina wrote: > can ...

7 years, 5 months ago (2013-07-15 12:05:04 UTC) #3

bsalomon

Awesome! Thanks for fixing that. Can we we call the new files SkGpuBlurUtils or SkBlurGpuUtils?

7 years, 5 months ago (2013-07-15 13:17:46 UTC) #4

bsalomon

On 2013/07/15 13:17:46, bsalomon wrote: > Awesome! Thanks for fixing that. Can we we call ...

7 years, 5 months ago (2013-07-15 13:19:54 UTC) #5

Message was sent while issue was closed.

committed as r10080

Expand Messages | Collapse Messages