Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

BUG=554298
Committed: https://crrev.com/5197113e6864b0530dd8b489615c089facd06e70
Cr-Commit-Position: refs/heads/master@{#386865}

[dcheng, 2016-04-11 18:26:26]

dcheng@chromium.org changed reviewers:
+ megjablon@chromium.org

[dcheng, 2016-04-11 18:26:27]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[megjablon, 2016-04-12 21:55:36]

https://codereview.chromium.org/1873263002/diff/1/chrome/browser/net/spdyprox...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
(right):

https://codereview.chromium.org/1873263002/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h:11: #include
"base/memory/scoped_ptr.h"
Unnecessary include

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc:6:

#include <memory>

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:7:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc:10:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc:10:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:7:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc:9:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc:7:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:10:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc:21:
src->GetList(pref_path)->DeepCopy());
#include <memory> ?

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc:12:
#include <memory>
Unnecessary include

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:19:
std::unique_ptr<base::Value> BuildDataReductionProxyEvent(
#include <memory> ?

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h:10:
#include <memory>
Unnecessary include

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.cc:7:
#include <memory>
Can be eliminated since it's in .h

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc:37:
std::unique_ptr<TestDataReductionProxyEventStorageDelegate> storage_delegate_;
#include <memory> ?

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:7:
#include <memory>
Unnecessary include

[dcheng, 2016-04-12 22:38:34]

https://codereview.chromium.org/1873263002/diff/1/chrome/browser/net/spdyprox...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
(right):

https://codereview.chromium.org/1873263002/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h:11: #include
"base/memory/scoped_ptr.h"
On 2016/04/12 21:55:35, megjablon wrote:
> Unnecessary include

This is required to keep the build from breaking: this file uses scoped_ptr.

To prevent the size of the patch from exploding, I minimize the fixes outside of
the target directory being converted.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc:6:

On 2016/04/12 21:55:35, megjablon wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:7:
#include <memory>
On 2016/04/12 21:55:35, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc:10:
#include <memory>
On 2016/04/12 21:55:35, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc:10:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:7:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc:9:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc:7:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:10:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc:21:
src->GetList(pref_path)->DeepCopy());
On 2016/04/12 21:55:36, megjablon wrote:
> #include <memory> ?

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc:12:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Unnecessary include

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc:19:
std::unique_ptr<base::Value> BuildDataReductionProxyEvent(
On 2016/04/12 21:55:36, megjablon wrote:
> #include <memory> ?

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h:10:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Unnecessary include 

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.cc:7:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Can be eliminated since it's in .h

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc:37:
std::unique_ptr<TestDataReductionProxyEventStorageDelegate> storage_delegate_;
On 2016/04/12 21:55:36, megjablon wrote:
> #include <memory> ?

Done.

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1873263002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:7:
#include <memory>
On 2016/04/12 21:55:36, megjablon wrote:
> Unnecessary include

Done.

[megjablon, 2016-04-12 22:41:13]

LGTM

https://codereview.chromium.org/1873263002/diff/1/chrome/browser/net/spdyprox...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
(right):

https://codereview.chromium.org/1873263002/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h:11: #include
"base/memory/scoped_ptr.h"
On 2016/04/12 22:38:34, dcheng wrote:
> On 2016/04/12 21:55:35, megjablon wrote:
> > Unnecessary include
> 
> This is required to keep the build from breaking: this file uses scoped_ptr.
> 
> To prevent the size of the patch from exploding, I minimize the fixes outside
of
> the target directory being converted.

Ah gotcha, makes sense.

[dcheng, 2016-04-12 22:53:06]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-12 22:53:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873263002/20001

[commit-bot: I haz the power, 2016-04-12 23:44:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 23:46:01]

Description was changed from

==========
Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

BUG=554298

Committed: https://crrev.com/5197113e6864b0530dd8b489615c089facd06e70
Cr-Commit-Position: refs/heads/master@{#386865}
==========

[commit-bot: I haz the power, 2016-04-12 23:46:02]

Patchset 2 (id:??) landed as
https://crrev.com/5197113e6864b0530dd8b489615c089facd06e70
Cr-Commit-Position: refs/heads/master@{#386865}