components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc - Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

index 0bfd7225a462f0f41a81acddbbaf0eb97722275f..59c95299f9d02e896e0ee6484eedd97674964279 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

@@ -216,7 +216,7 @@ class SecureProxyChecker : public net::URLFetcherDelegate {

scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;

// The URLFetcher being used for the secure proxy check.

- scoped_ptr<net::URLFetcher> fetcher_;

+ std::unique_ptr<net::URLFetcher> fetcher_;

FetcherResponseCallback fetcher_callback_;

// Used to determine the latency in performing the Data Reduction Proxy secure

@@ -228,7 +228,7 @@ class SecureProxyChecker : public net::URLFetcherDelegate {

DataReductionProxyConfig::DataReductionProxyConfig(

net::NetLog* net_log,

- scoped_ptr<DataReductionProxyConfigValues> config_values,

+ std::unique_ptr<DataReductionProxyConfigValues> config_values,

DataReductionProxyConfigurator* configurator,

DataReductionProxyEventCreator* event_creator)

: secure_proxy_allowed_(params::ShouldUseSecureProxyByDefault()),