components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc - Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc

Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc

index 835f6725fa338e3b29a96aaf1e8107ca8a782b80..92edf1f3355addcb32dd0569d7b98fc52f2829a1 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc

@@ -10,10 +10,10 @@

namespace data_reduction_proxy {

-scoped_ptr<DataReductionProxyMutableConfigValues>

+std::unique_ptr<DataReductionProxyMutableConfigValues>

DataReductionProxyMutableConfigValues::CreateFromParams(

const DataReductionProxyParams* params) {

- scoped_ptr<DataReductionProxyMutableConfigValues> config_values(

+ std::unique_ptr<DataReductionProxyMutableConfigValues> config_values(

new DataReductionProxyMutableConfigValues());

config_values->promo_allowed_ = params->promo_allowed();

config_values->holdback_ = params->holdback();