components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc - Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

index 0bc39ae8f226d66549692669acfba3fc48ff8ab6..092c48c2006ab65776948917c59c2d1b663df82b 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

@@ -185,7 +185,7 @@ TEST(DataReductionProxySettingsStandaloneTest, TestEndToEndSecureProxyCheck) {

for (const TestCase& test_case : kTestCases) {

net::TestURLRequestContext context(true);

- scoped_ptr<DataReductionProxyTestContext> drp_test_context =

+ std::unique_ptr<DataReductionProxyTestContext> drp_test_context =

DataReductionProxyTestContext::Builder()

.WithURLRequestContext(&context)

.WithTestConfigurator()

@@ -221,7 +221,7 @@ TEST(DataReductionProxySettingsStandaloneTest, TestEndToEndSecureProxyCheck) {

TEST(DataReductionProxySettingsStandaloneTest, TestOnProxyEnabledPrefChange) {

base::MessageLoopForIO message_loop;

- scoped_ptr<DataReductionProxyTestContext> drp_test_context =

+ std::unique_ptr<DataReductionProxyTestContext> drp_test_context =

DataReductionProxyTestContext::Builder()

.WithMockConfig()

.WithTestConfigurator()

@@ -539,7 +539,7 @@ TEST_F(DataReductionProxySettingsTest, TestLoFiSessionStateHistograms) {

settings_->SetDataReductionProxyEnabled(false);

settings_->data_reduction_proxy_service_->InitializeLoFiPrefs();

test_context_->RunUntilIdle();

- scoped_ptr<base::HistogramSamples> samples(

+ std::unique_ptr<base::HistogramSamples> samples(

histogram_tester.GetHistogramSamplesSinceCreation(kUMALoFiSessionState));

EXPECT_EQ(0, samples->TotalCount());