components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc - Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

index 3d9af5639b3b179a220a80e4134bbf1c4c6ff011..f6566357b581fe6830832bc0b3386e1afe316198 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

@@ -4,10 +4,10 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h"

+#include <memory>

#include <string>

#include <vector>

-#include "base/memory/scoped_ptr.h"

#include "base/values.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"

#include "net/proxy/proxy_server.h"

@@ -60,8 +60,8 @@ class DataReductionProxyConfiguratorTest : public testing::Test {

}

base::MessageLoop message_loop_;

- scoped_ptr<DataReductionProxyTestContext> test_context_;

- scoped_ptr<DataReductionProxyConfigurator> config_;

+ std::unique_ptr<DataReductionProxyTestContext> test_context_;

+ std::unique_ptr<DataReductionProxyConfigurator> config_;

};

TEST_F(DataReductionProxyConfiguratorTest, TestUnrestricted) {