components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc - Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc

Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc

index a8b409a82e94e9d3c91db10c6866ebc56aa7a6ec..34df69877a60d31c29c64ede2b5fb730471a1514 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc

@@ -7,7 +7,6 @@

#include <vector>

#include "base/command_line.h"

-#include "base/memory/scoped_ptr.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h"

#include "net/proxy/proxy_server.h"

@@ -34,8 +33,8 @@ class DataReductionProxyMutableConfigValuesTest : public testing::Test {

}

private:

- scoped_ptr<DataReductionProxyParams> params_;

- scoped_ptr<DataReductionProxyMutableConfigValues> mutable_config_values_;

+ std::unique_ptr<DataReductionProxyParams> params_;

+ std::unique_ptr<DataReductionProxyMutableConfigValues> mutable_config_values_;

};

TEST_F(DataReductionProxyMutableConfigValuesTest, UpdateValuesAndInvalidate) {