components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h - Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

index 36d2cd31b400508d62062db5e219f2e20584d9f5..8a7b6cf070b055e00645a587dae1135d5e187e65 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

@@ -5,10 +5,10 @@

#ifndef COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_MUTABLE_CONFIG_VALUES_H_

#define COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_MUTABLE_CONFIG_VALUES_H_

+#include <memory>

#include <vector>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/threading/thread_checker.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h"

#include "net/proxy/proxy_server.h"

@@ -25,8 +25,8 @@ class DataReductionProxyMutableConfigValues

public:

// Creates a new |DataReductionProxyMutableConfigValues| using |params| as

// the basis for its initial values.

- static scoped_ptr<DataReductionProxyMutableConfigValues> CreateFromParams(

- const DataReductionProxyParams* params);

+ static std::unique_ptr<DataReductionProxyMutableConfigValues>

+ CreateFromParams(const DataReductionProxyParams* params);

~DataReductionProxyMutableConfigValues() override;