Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr (Closed)

Created:
4 years, 8 months ago by vabr (Chromium)
Modified:
4 years, 8 months ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/password_manager: scoped_ptr -> unique_ptr In response to https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-QucCgAJ, which I hope was not an April Fool's joke. :) BUG=600221 Committed: https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015 Cr-Commit-Position: refs/heads/master@{#384885}

Patch Set 1 #

Patch Set 2 : Fix Windows -- revert unwanted change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -343 lines) Patch
M chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.h View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 6 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 15 chunks +27 lines, -39 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/native_backend_libsecret.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 80 chunks +84 lines, -83 lines 0 comments Download
M chrome/browser/password_manager/password_manager_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager_internals_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 10 chunks +51 lines, -46 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 19 chunks +24 lines, -23 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 9 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 6 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.h View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc View 6 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/update_password_infobar_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/update_password_infobar_delegate.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vabr (Chromium)
Hi Vadym, PTAL at this rather mechanical refactoring. Thanks! Vaclav
4 years, 8 months ago (2016-04-04 02:19:45 UTC) #3
dvadym
LGTM, thanks for this refactoring! But I'd recommend to take your time and not to ...
4 years, 8 months ago (2016-04-04 09:19:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858513002/20001
4 years, 8 months ago (2016-04-04 11:12:23 UTC) #6
vabr (Chromium)
Thanks Vadym! Don't worry, I used the day to cycle trough the city. :) Cheers, ...
4 years, 8 months ago (2016-04-04 11:13:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 12:03:23 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 12:04:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015
Cr-Commit-Position: refs/heads/master@{#384885}

Powered by Google App Engine
This is Rietveld 408576698