chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc - Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows -- revert unwanted change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/password_manager/native_backend_libsecret.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

index af3bffa2ace0d129e601f63ebc95d0888c663a96..df4cbb3a06051fde54898de18bbc22296bc14356 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

@@ -503,7 +503,7 @@ dbus::Response* NativeBackendKWalletTest::KLauncherMethodCall(

if (kwallet_runnable_)

kwallet_running_ = true;

- scoped_ptr<dbus::Response> response(dbus::Response::CreateEmpty());

+ std::unique_ptr<dbus::Response> response(dbus::Response::CreateEmpty());

dbus::MessageWriter writer(response.get());

writer.AppendInt32(klauncher_ret_);

writer.AppendString(std::string()); // dbus_name

@@ -520,7 +520,7 @@ dbus::Response* NativeBackendKWalletTest::KWalletMethodCall(

if (ContainsKey(failing_methods_, method_call->GetMember()))

return nullptr;

- scoped_ptr<dbus::Response> response;

+ std::unique_ptr<dbus::Response> response;

if (method_call->GetMember() == "isEnabled") {

response = dbus::Response::CreateEmpty();

dbus::MessageWriter writer(response.get());