chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows -- revert unwanted change Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/password_manager/native_backend_gnome_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index d94838510f851c75085d0e382df7d55bd5b03c14..056525ff81a38136ad85c774ee3ef2d6e1ffe171 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -168,7 +168,7 @@ TEST_F(ChromePasswordManagerClientTest,

TEST_F(ChromePasswordManagerClientTest,

IsAutomaticPasswordSavingEnabledWhenFlagIsSetTest) {

// Add the enable-automatic-password-saving feature.

- scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);

+ std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);

std::vector<const base::Feature*> enabled_features;

std::vector<const base::Feature*> disabled_features;

enabled_features.push_back(

@@ -284,7 +284,7 @@ TEST_F(ChromePasswordManagerClientTest,

}

TEST_F(ChromePasswordManagerClientTest, SavingAndFillingEnabledConditionsTest) {

- scoped_ptr<MockChromePasswordManagerClient> client(

+ std::unique_ptr<MockChromePasswordManagerClient> client(

new MockChromePasswordManagerClient(web_contents()));

// Functionality disabled if there is SSL errors.

EXPECT_CALL(*client, DidLastPageLoadEncounterSSLErrors())