chrome/browser/password_manager/password_manager_interactive_uitest.cc - Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_interactive_uitest.cc

Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows -- revert unwanted change Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/browser/password_manager/password_manager_internals_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_interactive_uitest.cc

diff --git a/chrome/browser/password_manager/password_manager_interactive_uitest.cc b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

index 1f060d1689ae2373adcc9be271ae0f61d5ad31d6..533c38031359510764debef898c036ac67845b7a 100644

--- a/chrome/browser/password_manager/password_manager_interactive_uitest.cc

+++ b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

@@ -45,7 +45,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, UsernameChanged) {

NavigateToFile("/password/signup_form.html");

NavigationObserver observer(WebContents());

- scoped_ptr<PromptObserver> prompt_observer(

+ std::unique_ptr<PromptObserver> prompt_observer(

PromptObserver::Create(WebContents()));

std::string fill_and_submit =

"document.getElementById('username_field').value = 'temp';"

@@ -84,7 +84,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, UsernameChanged) {

WaitForElementValue("username_field", "tempORARY");

NavigationObserver second_observer(WebContents());

- scoped_ptr<PromptObserver> second_prompt_observer(

+ std::unique_ptr<PromptObserver> second_prompt_observer(

PromptObserver::Create(WebContents()));

std::string submit =

"document.getElementById('input_submit_button').click();";