chrome/browser/password_manager/simple_password_store_mac_unittest.cc - Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/simple_password_store_mac_unittest.cc

Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows -- revert unwanted change Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/simple_password_store_mac.cc ('k') | chrome/browser/password_manager/update_password_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/simple_password_store_mac_unittest.cc

diff --git a/chrome/browser/password_manager/simple_password_store_mac_unittest.cc b/chrome/browser/password_manager/simple_password_store_mac_unittest.cc

index 26f459bbb8191c1ca518d483c31efce44f54389a..a2a641f646ab60ba9e374102d1d612cb3dce5ef5 100644

--- a/chrome/browser/password_manager/simple_password_store_mac_unittest.cc

+++ b/chrome/browser/password_manager/simple_password_store_mac_unittest.cc

@@ -41,7 +41,7 @@ class SimplePasswordStoreMacTest : public testing::Test {

OSCrypt::UseMockKeychain(true);

// Setup LoginDatabase.

- scoped_ptr<password_manager::LoginDatabase> login_db(

+ std::unique_ptr<password_manager::LoginDatabase> login_db(

new password_manager::LoginDatabase(test_login_db_file_path()));

scoped_refptr<base::SingleThreadTaskRunner> file_task_runner =

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE);

@@ -51,7 +51,7 @@ class SimplePasswordStoreMacTest : public testing::Test {

base::Bind(&InitOnBackgroundThread, base::Unretained(login_db.get())));

store_ = new SimplePasswordStoreMac(

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI), nullptr,

- scoped_ptr<password_manager::LoginDatabase>());

+ std::unique_ptr<password_manager::LoginDatabase>());

file_task_runner->PostTask(

FROM_HERE,

base::Bind(&SimplePasswordStoreMac::InitWithTaskRunner, store_,