Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: chrome/browser/password_manager/password_manager_internals_service_unittest.cc

Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows -- revert unwanted change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_internals_service_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_internals_service_unittest.cc b/chrome/browser/password_manager/password_manager_internals_service_unittest.cc
index bd125defa61c5e1b394058a464658d4d9d0fe91c..07b9c7af5cd2ee62a0efe9bf977cde2af21b119c 100644
--- a/chrome/browser/password_manager/password_manager_internals_service_unittest.cc
+++ b/chrome/browser/password_manager/password_manager_internals_service_unittest.cc
@@ -28,9 +28,9 @@ class MockLogReceiver : public password_manager::LogReceiver {
enum ProfileType { NORMAL_PROFILE, INCOGNITO_PROFILE };
-scoped_ptr<TestingProfile> CreateProfile(ProfileType type) {
+std::unique_ptr<TestingProfile> CreateProfile(ProfileType type) {
TestingProfile::Builder builder;
- scoped_ptr<TestingProfile> profile(builder.Build());
+ std::unique_ptr<TestingProfile> profile(builder.Build());
#if !defined(NDEBUG)
// During the test cases, the profiles may get created on the same address. To
// avoid over-zealous asserts we need to mark the newly created one as "live".
@@ -54,7 +54,7 @@ class PasswordManagerInternalsServiceTest : public testing::Test {
// When the profile is not incognito, it should be possible to activate the
// service.
TEST_F(PasswordManagerInternalsServiceTest, ServiceActiveNonIncognito) {
- scoped_ptr<TestingProfile> profile(CreateProfile(NORMAL_PROFILE));
+ std::unique_ptr<TestingProfile> profile(CreateProfile(NORMAL_PROFILE));
PasswordManagerInternalsService* service =
PasswordManagerInternalsServiceFactory::GetForBrowserContext(
profile.get());
@@ -74,7 +74,7 @@ TEST_F(PasswordManagerInternalsServiceTest, ServiceActiveNonIncognito) {
// When the browser profile is incognito, it should not be possible to activate
// the service.
TEST_F(PasswordManagerInternalsServiceTest, ServiceNotActiveIncognito) {
- scoped_ptr<TestingProfile> profile(CreateProfile(INCOGNITO_PROFILE));
+ std::unique_ptr<TestingProfile> profile(CreateProfile(INCOGNITO_PROFILE));
ASSERT_TRUE(profile);
Profile* incognito_profile = profile->GetOffTheRecordProfile();

Powered by Google App Engine
This is Rietveld 408576698