Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1858513002: chrome/browser/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows -- revert unwanted change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 0579c324fbd26d1415a97e3b91cdcba0150d1129..719c1f53af7a95065b68846ec5528ea4f4c69c2e 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -213,7 +213,7 @@ bool ChromePasswordManagerClient::IsFillingEnabledForCurrentPage() const {
}
bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
- scoped_ptr<password_manager::PasswordFormManager> form_to_save,
+ std::unique_ptr<password_manager::PasswordFormManager> form_to_save,
password_manager::CredentialSourceType type,
bool update_password) {
// Save password infobar and the password bubble prompts in case of
@@ -316,7 +316,7 @@ void ChromePasswordManagerClient::NotifyUserAutoSignin(
}
void ChromePasswordManagerClient::NotifyUserCouldBeAutoSignedIn(
- scoped_ptr<autofill::PasswordForm> form) {
+ std::unique_ptr<autofill::PasswordForm> form) {
possible_auto_sign_in_ = std::move(form);
}
@@ -341,7 +341,7 @@ void ChromePasswordManagerClient::NotifySuccessfulLoginWithExistingPassword(
}
void ChromePasswordManagerClient::AutomaticPasswordSave(
- scoped_ptr<password_manager::PasswordFormManager> saved_form) {
+ std::unique_ptr<password_manager::PasswordFormManager> saved_form) {
#if BUILDFLAG(ANDROID_JAVA_UI)
GeneratedPasswordSavedInfoBarDelegateAndroid::Create(web_contents());
#else
@@ -357,8 +357,8 @@ void ChromePasswordManagerClient::AutomaticPasswordSave(
void ChromePasswordManagerClient::PasswordWasAutofilled(
const autofill::PasswordFormMap& best_matches,
const GURL& origin,
- const std::vector<scoped_ptr<autofill::PasswordForm>>* federated_matches)
- const {
+ const std::vector<std::unique_ptr<autofill::PasswordForm>>*
+ federated_matches) const {
#if !BUILDFLAG(ANDROID_JAVA_UI)
PasswordsClientUIDelegate* manage_passwords_ui_controller =
PasswordsClientUIDelegateFromWebContents(web_contents());
@@ -397,7 +397,7 @@ ChromePasswordManagerClient::GetPasswordSyncState() const {
bool ChromePasswordManagerClient::WasLastNavigationHTTPError() const {
DCHECK(web_contents());
- scoped_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
+ std::unique_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
if (log_manager_->IsLoggingActive()) {
logger.reset(new password_manager::BrowserSavePasswordProgressLogger(
log_manager_.get()));

Powered by Google App Engine
This is Rietveld 408576698