Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 18584011: Rename base::Delete to base::DeleteFile (Closed)

Created:
7 years, 5 months ago by brettw
Modified:
7 years, 5 months ago
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), felt, nkostylev+watch_chromium.org, tzik+watch_chromium.org, rpetterson, browser-components-watch_chromium.org, gavinp+memory_chromium.org, dcheng, chrome-speed-team+watch_google.com, rginda+watch_chromium.org, kinuko+watch, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, sergeyu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, marja+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, michaeln, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, amit, jamiewalch+watch_chromium.org, derat+watch_chromium.org, tbarzic+watch_chromium.org, wez+watch_chromium.org, sanjeevr, haitaol+watch_chromium.org, rouslan+spellwatch_chromium.org, dsinclair+watch_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, dcaiafa+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, weitaosu+watch_chromium.org, Lei Zhang, tfarina, garykac+watch_chromium.org, tommycli, eroman, robertshield, mmenke, Greg Billock, alexeypa+watch_chromium.org, rsimha+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename base::Delete to base::DeleteFile Also renames DeleteAfterReboot to DeleteFileAfterReboot, and removes FileUtilProxy::RecursiveDelete which was never called. BUG= R=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211822

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -455 lines) Patch
M base/debug/trace_event_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_util_posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/file_util_unittest.cc View 20 chunks +27 lines, -27 lines 0 comments Download
M base/file_util_win.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 1 11 chunks +12 lines, -12 lines 0 comments Download
M base/files/file_util_proxy.h View 1 chunk +4 lines, -11 lines 0 comments Download
M base/files/file_util_proxy.cc View 1 2 chunks +5 lines, -16 lines 0 comments Download
M base/files/file_util_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/files/scoped_temp_dir.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/scoped_temp_dir_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_value_serializer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/crash_dump_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/contacts/contact_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/imageburner/burn_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/app_pack_updater.cc View 1 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/syslogs_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/test_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 1 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/record/record_api_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/text_database_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_profile_lock_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/net_log_temp_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/resource_cache.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sessions/session_backend.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/value_store/leveldb_value_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/auto_start_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/test/upgrade_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/tools/validate_installation_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_after_reboot_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/logging/win/test_log_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/generate_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/convert_dict_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/pmp_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/crash_reporting/minidump_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_scrubber.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/session_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/common/win/install_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/installer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cloud_print/service/win/service_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/visitedlink/test/visitedlink_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_file_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_pixel_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_drag_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/cache_util_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/cache_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/unix_domain_socket_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_response_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M printing/backend/cups_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M printing/backend/print_backend_cups.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/config_file_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/pairing_registry_delegate_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sync/syncable/on_disk_directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_storage_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/database/vfs_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/session_storage_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_usage_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_database_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_isolated_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/blob/scoped_file.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/plugin_instance.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_stream_posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
You complain, you get a 200 file code review.
7 years, 5 months ago (2013-07-11 18:06:14 UTC) #1
Scott Hess - ex-Googler
On 2013/07/11 18:06:14, brettw wrote: > You complain, you get a 200 file code review. ...
7 years, 5 months ago (2013-07-11 18:11:39 UTC) #2
brettw
7 years, 5 months ago (2013-07-16 19:10:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r211822.

Powered by Google App Engine
This is Rietveld 408576698