chrome/installer/util/installer_state.cc - Issue 18584011: Rename base::Delete to base::DeleteFile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/installer_state.cc

Issue 18584011: Rename base::Delete to base::DeleteFile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/installer_state.cc

diff --git a/chrome/installer/util/installer_state.cc b/chrome/installer/util/installer_state.cc

index ad8c0539394af4516d15cb796467cde08aa20af3..32d9b5acb4d63822ca22c65a39e16a21a9a016a2 100644

--- a/chrome/installer/util/installer_state.cc

+++ b/chrome/installer/util/installer_state.cc

@@ -665,7 +665,7 @@ void InstallerState::RemoveOldVersionDirectories(

LOG(ERROR) << "Deleting old version directory: " << next_version.value();

// Attempt to recursively delete the old version dir.

- bool delete_succeeded = base::Delete(next_version, true);

+ bool delete_succeeded = base::DeleteFile(next_version, true);

// Note: temporarily log old version deletion at ERROR level to make it

// more likely we see this in the installer log.