Update new Surface callsites

Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome. This helps
us migrate from raw pointers to sk_sp<> smart pointers
in Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8be900724dbaa615308f734c6ef2263357f2a0ab
Cr-Commit-Position: refs/heads/master@{#385498}

[tomhudson, 2016-04-04 15:22:40]

Description was changed from

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
==========

to

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tomhudson, 2016-04-04 15:39:37]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 15:39:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/1

[commit-bot: I haz the power, 2016-04-04 15:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 15:54:41]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tomhudson, 2016-04-04 17:38:35]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 17:39:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/20001

[commit-bot: I haz the power, 2016-04-04 17:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 17:58:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tomhudson, 2016-04-04 18:18:41]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 18:19:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/40001

[commit-bot: I haz the power, 2016-04-04 19:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:36:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tomhudson, 2016-04-05 12:04:34]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 12:04:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/60001

[commit-bot: I haz the power, 2016-04-05 12:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 12:07:02]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tomhudson, 2016-04-05 12:29:14]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 12:29:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/80001

[commit-bot: I haz the power, 2016-04-05 12:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 12:52:21]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tomhudson, 2016-04-05 13:08:59]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 13:09:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/100001

[tomhudson, 2016-04-05 13:55:34]

Another legacy API we can stop supporting in Chrome.

[reed1, 2016-04-05 14:06:16]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-04-05 14:06:17]

https://codereview.chromium.org/1855273002/diff/100001/cc/raster/tile_task_wo...
File cc/raster/tile_task_worker_pool.cc (right):

https://codereview.chromium.org/1855273002/diff/100001/cc/raster/tile_task_wo...
cc/raster/tile_task_worker_pool.cc:130:
surface->getCanvas()->readPixels(dst_info, memory, stride, 0, 0);
nit: could change to surface->readPixels() // but not required for this CL

[reed1, 2016-04-05 14:06:33]

lgtm

[f(malita), 2016-04-05 14:31:52]

LGTM

Meta-nit: can you check whether we can remove skia/ext/refptr.h includes from
the updated Chromium headers?

https://codereview.chromium.org/1855273002/diff/100001/ui/ozone/platform/drm/...
File ui/ozone/platform/drm/gpu/drm_buffer.cc (left):

https://codereview.chromium.org/1855273002/diff/100001/ui/ozone/platform/drm/...
ui/ozone/platform/drm/gpu/drm_buffer.cc:41: surface_.clear();
I think we should leave this alone (security/DRM implications?).

[tomhudson, 2016-04-05 14:52:49]

tomhudson@google.com changed reviewers:
- reed@chromium.org

[tomhudson, 2016-04-05 14:52:50]

> Meta-nit: can you check whether we can remove skia/ext/refptr.h includes from
> the updated Chromium headers?

Done. Only 2 for now; even cc/ still has more than 150 skia::RefPtr instances,
mostly of SkImage, SkImageFilter, and SkCanvas. One of my OKRs for this quarter
is likely attacking the migration to sk_sp<> from that direction: look at what
Chrome uses and update Skia to fit.

https://codereview.chromium.org/1855273002/diff/100001/cc/raster/tile_task_wo...
File cc/raster/tile_task_worker_pool.cc (right):

https://codereview.chromium.org/1855273002/diff/100001/cc/raster/tile_task_wo...
cc/raster/tile_task_worker_pool.cc:130:
surface->getCanvas()->readPixels(dst_info, memory, stride, 0, 0);
On 2016/04/05 14:06:17, reed1 wrote:
> nit: could change to surface->readPixels() // but not required for this CL

Done.

https://codereview.chromium.org/1855273002/diff/100001/ui/ozone/platform/drm/...
File ui/ozone/platform/drm/gpu/drm_buffer.cc (left):

https://codereview.chromium.org/1855273002/diff/100001/ui/ozone/platform/drm/...
ui/ozone/platform/drm/gpu/drm_buffer.cc:41: surface_.clear();
On 2016/04/05 14:31:52, f(malita) wrote:
> I think we should leave this alone (security/DRM implications?).

I thought surface_->clear() would be significant, but surface_.clear() is just
zeroing out the pointer, which the sk_sp destructor will do for us?

Or am I misreading?

[f(malita), 2016-04-05 14:56:02]

https://codereview.chromium.org/1855273002/diff/100001/ui/ozone/platform/drm/...
File ui/ozone/platform/drm/gpu/drm_buffer.cc (left):

https://codereview.chromium.org/1855273002/diff/100001/ui/ozone/platform/drm/...
ui/ozone/platform/drm/gpu/drm_buffer.cc:41: surface_.clear();
On 2016/04/05 14:52:50, tomhudson wrote:
> On 2016/04/05 14:31:52, f(malita) wrote:
> > I think we should leave this alone (security/DRM implications?).
> 
> I thought surface_->clear() would be significant, but surface_.clear() is just
> zeroing out the pointer, which the sk_sp destructor will do for us?
> 
> Or am I misreading?

You're right - I was thinking this clears the surface, not the pointer. 
Disregard my comment.

[tomhudson, 2016-04-05 14:58:14]

tomhudson@google.com changed reviewers:
+ danakj@chromium.org, dnicoara@chromium.org, junov@chromium.org,
piman@chromium.org, rjkroege@chromium.org

[tomhudson, 2016-04-05 14:58:15]

danakj@: please review cc/, ui/gfx/
piman@: please review content/browser/gpu/
junov@: please review WebKit/Source/modules/
dnicoara@: please review ui/ozone/platform/drm/
rjkroege@: please review the rest of ui/ozone/

[tomhudson, 2016-04-05 14:58:45]

Description was changed from

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome. This helps
us migrate from raw pointers to sk_sp<> smart pointers
in Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[piman, 2016-04-05 15:21:34]

lgtm

[danakj, 2016-04-05 18:03:45]

LGTM

[dnicoara, 2016-04-05 18:43:28]

ui/ozone/platform/drm lgtm

[rjkroege, 2016-04-05 19:19:21]

ui/ozone lgtm

[haraken, 2016-04-05 23:29:57]

WebKit LGTM

[tomhudson, 2016-04-06 13:48:50]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-04-06 13:48:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/1855273002/#ps120001
(title: "review")

[commit-bot: I haz the power, 2016-04-06 13:49:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/120001

[commit-bot: I haz the power, 2016-04-06 14:18:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 14:18:44]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tomhudson, 2016-04-06 14:59:17]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 14:59:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/140001

[commit-bot: I haz the power, 2016-04-06 16:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 16:14:07]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-04-06 17:34:23]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-04-06 17:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, dnicoara@chromium.org, piman@chromium.org,
danakj@chromium.org, fmalita@chromium.org, haraken@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/1855273002/#ps140001
(title: "software_output_device was indirectly including skia::refptr, switch to
sk_sp<>")

[commit-bot: I haz the power, 2016-04-06 17:34:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855273002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855273002/140001

[commit-bot: I haz the power, 2016-04-06 17:42:41]

Description was changed from

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome. This helps
us migrate from raw pointers to sk_sp<> smart pointers
in Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome. This helps
us migrate from raw pointers to sk_sp<> smart pointers
in Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-06 17:42:43]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-06 17:43:54]

Description was changed from

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome. This helps
us migrate from raw pointers to sk_sp<> smart pointers
in Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update new Surface callsites

Replace deprecated SkSurface* NewFoo() calls with
sk_sp<SkSurface> MakeFoo() calls, allowing us to stop defining
SK_SUPPORT_LEGACY_NEW_SURFACE_API for Chrome. This helps
us migrate from raw pointers to sk_sp<> smart pointers
in Chrome.

R=reed@chromium.org,fmalita@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8be900724dbaa615308f734c6ef2263357f2a0ab
Cr-Commit-Position: refs/heads/master@{#385498}
==========

[commit-bot: I haz the power, 2016-04-06 17:43:57]

Patchset 8 (id:??) landed as
https://crrev.com/8be900724dbaa615308f734c6ef2263357f2a0ab
Cr-Commit-Position: refs/heads/master@{#385498}