third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 1855273002: Update new Surface callsites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 1855273002: Update new Surface callsites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: software_output_device was indirectly including skia::refptr, switch to sk_sp<> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index e9e1a28f2b7a0f01ffa819be4c9ccd386984d78b..03aed594ebe1ccbb56e744bf9fdb46ce227b05d7 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -126,7 +126,7 @@ bool canCreateImageBuffer(const IntSize& size)

PassRefPtr<Image> createTransparentImage(const IntSize& size)

{

ASSERT(canCreateImageBuffer(size));

- RefPtr<SkSurface> surface = adoptRef(SkSurface::NewRasterN32Premul(size.width(), size.height()));

+ sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(size.width(), size.height());

surface->getCanvas()->clear(SK_ColorTRANSPARENT);

return StaticBitmapImage::create(adoptRef(surface->newImageSnapshot()));

}