cc/output/gl_renderer.cc - Issue 1855273002: Update new Surface callsites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer.cc

Issue 1855273002: Update new Surface callsites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: software_output_device was indirectly including skia::refptr, switch to sk_sp<> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/gl_renderer.cc

diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc

index feef7e2870f16493562eb8a91d5b71e4e5934561..f618cfd6ae9ed5621ab55f63f7f98d879cc9723b 100644

--- a/cc/output/gl_renderer.cc

+++ b/cc/output/gl_renderer.cc

@@ -639,8 +639,8 @@ static skia::RefPtr<SkImage> ApplyImageFilter(

// Create surface to draw into.

SkImageInfo dst_info =

SkImageInfo::MakeN32Premul(dst_rect.width(), dst_rect.height());

- skia::RefPtr<SkSurface> surface = skia::AdoptRef(SkSurface::NewRenderTarget(

- use_gr_context->context(), SkBudgeted::kYes, dst_info, 0));

+ sk_sp<SkSurface> surface = SkSurface::MakeRenderTarget(

+ use_gr_context->context(), SkBudgeted::kYes, dst_info);

if (!surface) {

TRACE_EVENT_INSTANT0("cc", "ApplyImageFilter surface allocation failed",

TRACE_EVENT_SCOPE_THREAD);

« no previous file with comments | « cc/layers/picture_image_layer_unittest.cc ('k') | cc/output/renderer_pixeltest.cc » ('j') | no next file with comments »