content/browser/compositor/software_output_device_mac.mm - Issue 1855273002: Update new Surface callsites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_output_device_mac.mm

Issue 1855273002: Update new Surface callsites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: software_output_device was indirectly including skia::refptr, switch to sk_sp<> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/compositor/software_output_device_mac.mm

diff --git a/content/browser/compositor/software_output_device_mac.mm b/content/browser/compositor/software_output_device_mac.mm

index e71f6782878fb8915d7ceb7f27176454569040a9..4fd799382da9bb2db606fb054d9d1cdc6244e311 100644

--- a/content/browser/compositor/software_output_device_mac.mm

+++ b/content/browser/compositor/software_output_device_mac.mm

@@ -123,7 +123,7 @@ SkCanvas* SoftwareOutputDeviceMac::BeginPaint(

IOSurfaceGetBaseAddress(io_surfaces_[current_index_]));

size_t stride = IOSurfaceGetBytesPerRow(io_surfaces_[current_index_]);

- canvas_ = skia::AdoptRef(SkCanvas::NewRasterDirectN32(

+ canvas_ = sk_sp<SkCanvas>(SkCanvas::NewRasterDirectN32(

pixel_size_.width(), pixel_size_.height(), pixels, stride));

CopyPreviousBufferDamage(SkRegion(gfx::RectToSkIRect(new_damage_rect)));