third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp - Issue 1855273002: Update new Surface callsites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp

Issue 1855273002: Update new Surface callsites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: software_output_device was indirectly including skia::refptr, switch to sk_sp<> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp ('k') | third_party/WebKit/Source/platform/DragImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp

diff --git a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp

index 29438118d7b2b0dc12a30b07c39d82e756614dfb..ae6b34b2b8c18d4ae318f21d93afbc5b313df564 100644

--- a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp

+++ b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp

@@ -34,7 +34,7 @@ void ImageBitmapRenderingContext::transferImageBitmap(ImageBitmap* imageBitmap)

RefPtr<SkImage> skImage = m_image->imageForCurrentFrame();

if (skImage->isTextureBacked()) {

// TODO(junov): crbug.com/585607 Eliminate this readback and use an ExternalTextureLayer

- RefPtr<SkSurface> surface = adoptRef(SkSurface::NewRasterN32Premul(skImage->width(), skImage->height()));

+ sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(skImage->width(), skImage->height());

if (!surface) {

// silent failure

m_image.clear();