Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_{Byte,Wide}String::Equal in favor of "==". Makes the code slightly cleaner. Committed: https://pdfium.googlesource.com/pdfium/+/9f2970caec897c40b91bd010c04dfe1f19d11108

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -149 lines) Patch
M core/fpdfdoc/doc_basic_unittest.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M core/fpdfdoc/doc_formcontrol.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_bstring.cpp View 1 chunk +14 lines, -14 lines 0 comments Download
M core/fxcrt/fx_basic_wstring.cpp View 1 chunk +14 lines, -14 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 3 chunks +6 lines, -34 lines 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfppo.cpp View 1 3 chunks +2 lines, -5 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 4 chunks +29 lines, -33 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 5 chunks +9 lines, -10 lines 0 comments Download
M xfa/fxfa/parser/xfa_objectacc_imp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-03-31 23:12:15 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1846083002/diff/1/fpdfsdk/fpdfppo.cpp File fpdfsdk/fpdfppo.cpp (right): https://codereview.chromium.org/1846083002/diff/1/fpdfsdk/fpdfppo.cpp#newcode68 fpdfsdk/fpdfppo.cpp:68: if (cbRootType == "") { Replace with IsEmpty()? ...
4 years, 8 months ago (2016-04-01 01:02:36 UTC) #3
Tom Sepez
https://codereview.chromium.org/1846083002/diff/1/fpdfsdk/fpdfppo.cpp File fpdfsdk/fpdfppo.cpp (right): https://codereview.chromium.org/1846083002/diff/1/fpdfsdk/fpdfppo.cpp#newcode68 fpdfsdk/fpdfppo.cpp:68: if (cbRootType == "") { On 2016/04/01 01:02:36, Lei ...
4 years, 8 months ago (2016-04-01 17:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846083002/20001
4 years, 8 months ago (2016-04-01 17:07:07 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 17:23:12 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9f2970caec897c40b91bd010c04dfe1f19d1...

Powered by Google App Engine
This is Rietveld 408576698