Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: fpdfsdk/fpdfppo.cpp

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Nits. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/fpdfdoc.cpp ('k') | xfa/fwl/basewidget/fwl_comboboximp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/fpdfppo.cpp
diff --git a/fpdfsdk/fpdfppo.cpp b/fpdfsdk/fpdfppo.cpp
index 94fa6bae84fe0398f19b3d1a8c5430fb6af544a9..cab2c6c3e07b8e0ace8ae9fd4f8a26b04bf71127 100644
--- a/fpdfsdk/fpdfppo.cpp
+++ b/fpdfsdk/fpdfppo.cpp
@@ -54,7 +54,6 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document* pDestPDFDoc,
if (!pNewRoot)
return FALSE;
- // Set the document information
CPDF_Dictionary* DInfoDict = pDestPDFDoc->GetInfo();
if (!DInfoDict)
return FALSE;
@@ -63,11 +62,9 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document* pDestPDFDoc,
producerstr.Format("PDFium");
DInfoDict->SetAt("Producer", new CPDF_String(producerstr, FALSE));
- // Set type
CFX_ByteString cbRootType = pNewRoot->GetStringBy("Type", "");
- if (cbRootType.Equal("")) {
+ if (cbRootType.IsEmpty())
pNewRoot->SetAt("Type", new CPDF_Name("Catalog"));
- }
CPDF_Object* pElement = pNewRoot->GetObjectBy("Pages");
CPDF_Dictionary* pNewPages =
@@ -79,7 +76,7 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document* pDestPDFDoc,
}
CFX_ByteString cbPageType = pNewPages->GetStringBy("Type", "");
- if (cbPageType.Equal("")) {
+ if (cbPageType == "") {
pNewPages->SetAt("Type", new CPDF_Name("Pages"));
}
« no previous file with comments | « fpdfsdk/fpdfdoc.cpp ('k') | xfa/fwl/basewidget/fwl_comboboximp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698