Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: fpdfsdk/fpdfdoc.cpp

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fxcrt/include/fx_string.h ('k') | fpdfsdk/fpdfppo.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "public/fpdf_doc.h" 7 #include "public/fpdf_doc.h"
8 8
9 #include <set> 9 #include <set>
10 10
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 if (!pPage || !pPage->m_pFormDict) 284 if (!pPage || !pPage->m_pFormDict)
285 return FALSE; 285 return FALSE;
286 CPDF_Array* pAnnots = pPage->m_pFormDict->GetArrayBy("Annots"); 286 CPDF_Array* pAnnots = pPage->m_pFormDict->GetArrayBy("Annots");
287 if (!pAnnots) 287 if (!pAnnots)
288 return FALSE; 288 return FALSE;
289 for (int i = *startPos; i < (int)pAnnots->GetCount(); i++) { 289 for (int i = *startPos; i < (int)pAnnots->GetCount(); i++) {
290 CPDF_Dictionary* pDict = 290 CPDF_Dictionary* pDict =
291 ToDictionary(static_cast<CPDF_Object*>(pAnnots->GetDirectObjectAt(i))); 291 ToDictionary(static_cast<CPDF_Object*>(pAnnots->GetDirectObjectAt(i)));
292 if (!pDict) 292 if (!pDict)
293 continue; 293 continue;
294 if (pDict->GetStringBy("Subtype").Equal("Link")) { 294 if (pDict->GetStringBy("Subtype") == "Link") {
295 *startPos = i + 1; 295 *startPos = i + 1;
296 *linkAnnot = (FPDF_LINK)pDict; 296 *linkAnnot = (FPDF_LINK)pDict;
297 return TRUE; 297 return TRUE;
298 } 298 }
299 } 299 }
300 return FALSE; 300 return FALSE;
301 } 301 }
302 302
303 DLLEXPORT FPDF_BOOL STDCALL FPDFLink_GetAnnotRect(FPDF_LINK linkAnnot, 303 DLLEXPORT FPDF_BOOL STDCALL FPDFLink_GetAnnotRect(FPDF_LINK linkAnnot,
304 FS_RECTF* rect) { 304 FS_RECTF* rect) {
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 return 0; 364 return 0;
365 CFX_WideString text = pInfo->GetUnicodeTextBy(tag); 365 CFX_WideString text = pInfo->GetUnicodeTextBy(tag);
366 // Use UTF-16LE encoding 366 // Use UTF-16LE encoding
367 CFX_ByteString encodedText = text.UTF16LE_Encode(); 367 CFX_ByteString encodedText = text.UTF16LE_Encode();
368 unsigned long len = encodedText.GetLength(); 368 unsigned long len = encodedText.GetLength();
369 if (buffer && buflen >= len) { 369 if (buffer && buflen >= len) {
370 FXSYS_memcpy(buffer, encodedText.c_str(), len); 370 FXSYS_memcpy(buffer, encodedText.c_str(), len);
371 } 371 }
372 return len; 372 return len;
373 } 373 }
OLDNEW
« no previous file with comments | « core/fxcrt/include/fx_string.h ('k') | fpdfsdk/fpdfppo.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698