Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: xfa/fxfa/parser/xfa_parser_imp.cpp

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/parser/xfa_objectacc_imp.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/parser/xfa_parser_imp.h" 7 #include "xfa/fxfa/parser/xfa_parser_imp.h"
8 8
9 #include "xfa/fde/xml/fde_xml_imp.h" 9 #include "xfa/fde/xml/fde_xml_imp.h"
10 #include "xfa/fgas/crt/fgas_codepage.h" 10 #include "xfa/fgas/crt/fgas_codepage.h"
(...skipping 1438 matching lines...) Expand 10 before | Expand all | Expand 10 after
1449 break; 1449 break;
1450 case FDE_XMLSYNTAXSTATUS_ElementBreak: 1450 case FDE_XMLSYNTAXSTATUS_ElementBreak:
1451 break; 1451 break;
1452 case FDE_XMLSYNTAXSTATUS_ElementClose: 1452 case FDE_XMLSYNTAXSTATUS_ElementClose:
1453 if (m_pChild->GetType() != FDE_XMLNODE_Element) { 1453 if (m_pChild->GetType() != FDE_XMLNODE_Element) {
1454 m_dwStatus = FDE_XMLSYNTAXSTATUS_Error; 1454 m_dwStatus = FDE_XMLSYNTAXSTATUS_Error;
1455 break; 1455 break;
1456 } 1456 }
1457 m_pParser->GetTagName(m_ws1); 1457 m_pParser->GetTagName(m_ws1);
1458 static_cast<CFDE_XMLElement*>(m_pChild)->GetTagName(m_ws2); 1458 static_cast<CFDE_XMLElement*>(m_pChild)->GetTagName(m_ws2);
1459 if (m_ws1.GetLength() > 0 && !m_ws1.Equal(m_ws2)) { 1459 if (m_ws1.GetLength() > 0 && m_ws1 != m_ws2) {
1460 m_dwStatus = FDE_XMLSYNTAXSTATUS_Error; 1460 m_dwStatus = FDE_XMLSYNTAXSTATUS_Error;
1461 break; 1461 break;
1462 } 1462 }
1463 m_NodeStack.Pop(); 1463 m_NodeStack.Pop();
1464 if (m_NodeStack.GetSize() < 1) { 1464 if (m_NodeStack.GetSize() < 1) {
1465 m_dwStatus = FDE_XMLSYNTAXSTATUS_Error; 1465 m_dwStatus = FDE_XMLSYNTAXSTATUS_Error;
1466 break; 1466 break;
1467 } else if (m_dwCurrentCheckStatus != 0 && m_NodeStack.GetSize() == 2) { 1467 } else if (m_dwCurrentCheckStatus != 0 && m_NodeStack.GetSize() == 2) {
1468 m_nSize[m_dwCurrentCheckStatus - 1] = 1468 m_nSize[m_dwCurrentCheckStatus - 1] =
1469 m_pParser->GetCurrentBinaryPos() - 1469 m_pParser->GetCurrentBinaryPos() -
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
1555 break; 1555 break;
1556 } 1556 }
1557 if (pPause && iCount > 500 && pPause->NeedToPauseNow()) { 1557 if (pPause && iCount > 500 && pPause->NeedToPauseNow()) {
1558 break; 1558 break;
1559 } 1559 }
1560 } 1560 }
1561 return (m_dwStatus == FDE_XMLSYNTAXSTATUS_Error || m_NodeStack.GetSize() != 1) 1561 return (m_dwStatus == FDE_XMLSYNTAXSTATUS_Error || m_NodeStack.GetSize() != 1)
1562 ? -1 1562 ? -1
1563 : m_pParser->GetStatus(); 1563 : m_pParser->GetStatus();
1564 } 1564 }
OLDNEW
« no previous file with comments | « xfa/fxfa/parser/xfa_objectacc_imp.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698