xfa/fwl/basewidget/fwl_comboboximp.cpp - Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/basewidget/fwl_comboboximp.cpp

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nits. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/basewidget/fwl_comboboximp.cpp

diff --git a/xfa/fwl/basewidget/fwl_comboboximp.cpp b/xfa/fwl/basewidget/fwl_comboboximp.cpp

index 9d3a5db4c2b73d4891d64438531d7e2a1d83ccac..66d749a382ce499630eb24e3a0c9d701c0b724d1 100644

--- a/xfa/fwl/basewidget/fwl_comboboximp.cpp

+++ b/xfa/fwl/basewidget/fwl_comboboximp.cpp

@@ -1556,7 +1556,7 @@ void CFWL_ComboBoxImpDelegate::DoSubCtrlKey(CFWL_MsgKey* pMsg) {

FWL_HLISTITEM hItem = pData->GetItem(m_pOwner->m_pInterface, iCurSel);

static_cast<CFWL_ComboListImp*>(m_pOwner->m_pListBox->GetImpl())

->GetItemText(hItem, wsTemp);

- bMatchEqual = wsText.Equal(wsTemp);

+ bMatchEqual = wsText == wsTemp;

}

if (iCurSel < 0) {

@@ -1703,7 +1703,7 @@ void CFWL_ComboBoxImpDelegate::DisForm_OnKey(CFWL_MsgKey* pMsg) {

CFX_WideString wsTemp;

FWL_HLISTITEM item = m_pOwner->m_pListBox->GetSelItem(iCurSel);

m_pOwner->m_pListBox->GetItemText(item, wsTemp);

- bMatchEqual = wsText.Equal(wsTemp);

+ bMatchEqual = wsText == wsTemp;

}

if (iCurSel < 0) {

« no previous file with comments | « fpdfsdk/fpdfppo.cpp ('k') | xfa/fxfa/app/xfa_ffdoc.cpp » ('j') | no next file with comments »